Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flow for Page optional props (base template) #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AuroreM
Copy link

@AuroreM AuroreM commented Nov 26, 2017

PR related to this issue #149

@4ian
Copy link
Contributor

4ian commented Nov 28, 2017

@Almouro What is the best practise for the commits name? Is there documentation/some hint about this somewhere? ;)

@Almouro
Copy link
Member

Almouro commented Nov 28, 2017

Yes, here but it's not really clear enough.
It would be better to have this in the pull request template :)
I'm going to add this right now.

But yeah, @AuroreM, your commit should be starting with fix:

Copy link
Member

@Almouro Almouro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But yeah, @AuroreM, your commit should be starting with fix:

@Minishlink
Copy link
Contributor

Or maybe activate back Squash and merge so that you can rename directly (no rework)?

@tychota
Copy link
Contributor

tychota commented Jan 4, 2018

@AuroreM : ping

yleflour
yleflour previously approved these changes May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants