Bal 3035 #2986
Bal 3035 #2986
Conversation
|
WalkthroughThis pull request introduces multiple updates across various packages in the Ballerine ecosystem, focusing on version increments and dependency updates. Key changes include the addition of new version entries in the changelogs for Changes
Possibly related PRs
Suggested Reviewers
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (5)
packages/workflow-core/src/lib/plugins/external-plugin/types.ts (1)
30-31: LGTM! Consider adding JSDoc comments.The new optional properties are well-typed and align with the PR objectives. Consider adding JSDoc comments to document their purpose and usage.
export interface IApiPluginParams { + /** List of property names that are allowed in the plugin input */ whitelistedInputProperties?: string[]; + /** When true, includes the invocation timestamp in the plugin response */ includeInvokedAt?: boolean;apps/backoffice-v2/src/lib/blocks/hooks/useMerchantScreeningBlock/columns.tsx (1)
126-145: Consider extracting common JsonDialog rendering logic.There's duplicate code for rendering JsonDialog in both columns. Consider extracting this into a reusable component.
+const JsonDataCell = ({ data }: { data: unknown }) => ( + <div className={`flex items-end justify-start`}> + <JsonDialog + buttonProps={{ + variant: 'link', + className: 'p-0 text-blue-500', + disabled: !isObject(data) && !Array.isArray(data), + }} + dialogButtonText={`View`} + json={JSON.stringify(data)} + /> + </div> +); summaryColumnHelper.accessor('merchantScreeningInput', { header: 'Checked Properties', cell: info => { - const fullJsonData = info.getValue(); - return ( - <div className={`flex items-end justify-start`}> - <JsonDialog - buttonProps={{ - variant: 'link', - className: 'p-0 text-blue-500', - disabled: !isObject(fullJsonData) && !Array.isArray(fullJsonData), - }} - dialogButtonText={`View`} - json={JSON.stringify(fullJsonData)} - /> - </div> - ); + return <JsonDataCell data={info.getValue()} />; }, }),Also applies to: 147-163
packages/workflow-core/src/lib/plugins/external-plugin/api-plugin/api-plugin.ts (1)
437-454: Consider optimizing the whitelist payload generation.The current implementation has a potential performance optimization opportunity:
- The recursive check for nested objects could be more efficient
- The empty value check at line 446 might skip valid falsy values
Consider this optimization:
generateRequestPayloadFromWhitelist(payload: AnyRecord = {}) { if (!this.whitelistedInputProperties) return payload; const whitelistedPayload: AnyRecord = {}; for (const key of this.whitelistedInputProperties) { const value = payload[key]; - whitelistedPayload[key] = value; - - if (value) continue; - if (typeof value === 'object' && !Array.isArray(value)) { whitelistedPayload[key] = this.generateRequestPayloadFromWhitelist(value as AnyRecord); + } else { + whitelistedPayload[key] = value; } } return whitelistedPayload; }packages/workflow-core/src/lib/workflow-runner.ts (1)
808-812: Consider consolidating duplicate context update logic.The same pattern for updating the context with plugin input is repeated in three places. This could be refactored into a helper method to improve maintainability and reduce code duplication.
Consider creating a helper method:
private updatePluginInputContext( pluginName: string, requestPayload: unknown, status: ProcessStatus, error?: unknown, ) { return this.mergeToContext( this.context, { requestPayload, ...(error ? { error } : {}), status }, `pluginsInput.${pluginName}`, ); }Then use it in place of the repeated blocks:
this.context = this.updatePluginInputContext( apiPlugin.name, requestPayload, error ? ProcessStatus.ERROR : ProcessStatus.SUCCESS, error, );Also applies to: 822-826, 836-840
packages/workflow-core/CHANGELOG.md (1)
7-7: Minor grammar improvement in changelog.When using "per", the following noun is typically singular.
-Added pluginsInput with requestPayload per plugins & invokedAt now disablable +Added pluginsInput with requestPayload per plugin & invokedAt now disablable🧰 Tools
🪛 LanguageTool
[uncategorized] ~7-~7: Did you mean “plugin”? If following ‘per’, nouns are often singular.
Context: ...ed pluginsInput with requestPayload per plugins & invokedAt now disablable ## 0.6.87 ...(CONFUSION_OF_NNS_NN_UN)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (29)
apps/backoffice-v2/CHANGELOG.md(1 hunks)apps/backoffice-v2/package.json(2 hunks)apps/backoffice-v2/src/domains/workflows/fetchers.ts(1 hunks)apps/backoffice-v2/src/lib/blocks/hooks/useMerchantScreeningBlock/columns.tsx(3 hunks)apps/backoffice-v2/src/lib/blocks/hooks/useMerchantScreeningBlock/useMerchantScreeningBlock.tsx(2 hunks)apps/backoffice-v2/src/lib/blocks/variants/DefaultBlocks/hooks/useDefaultBlocksLogic/useDefaultBlocksLogic.tsx(4 hunks)apps/kyb-app/CHANGELOG.md(1 hunks)apps/kyb-app/package.json(2 hunks)examples/headless-example/CHANGELOG.md(1 hunks)examples/headless-example/package.json(2 hunks)packages/workflow-core/CHANGELOG.md(1 hunks)packages/workflow-core/package.json(1 hunks)packages/workflow-core/src/lib/plugins/external-plugin/api-plugin/api-plugin-workflow-runner.test.ts(1 hunks)packages/workflow-core/src/lib/plugins/external-plugin/api-plugin/api-plugin.test.ts(1 hunks)packages/workflow-core/src/lib/plugins/external-plugin/api-plugin/api-plugin.ts(9 hunks)packages/workflow-core/src/lib/plugins/external-plugin/api-plugin/index.ts(1 hunks)packages/workflow-core/src/lib/plugins/external-plugin/individuals-sanctions-v2-plugin/individuals-sanctions-v2-plugin.test.ts(1 hunks)packages/workflow-core/src/lib/plugins/external-plugin/mastercard-merchant-screening-plugin.test.ts(1 hunks)packages/workflow-core/src/lib/plugins/external-plugin/mastercard-merchant-screening-plugin.ts(5 hunks)packages/workflow-core/src/lib/plugins/external-plugin/types.ts(2 hunks)packages/workflow-core/src/lib/plugins/types.ts(1 hunks)packages/workflow-core/src/lib/workflow-runner.ts(5 hunks)sdks/workflow-browser-sdk/CHANGELOG.md(1 hunks)sdks/workflow-browser-sdk/package.json(2 hunks)sdks/workflow-node-sdk/CHANGELOG.md(1 hunks)sdks/workflow-node-sdk/package.json(2 hunks)services/workflows-service/CHANGELOG.md(1 hunks)services/workflows-service/package.json(2 hunks)services/workflows-service/prisma/data-migrations(1 hunks)
✅ Files skipped from review due to trivial changes (15)
- packages/workflow-core/src/lib/plugins/external-plugin/api-plugin/index.ts
- packages/workflow-core/package.json
- services/workflows-service/prisma/data-migrations
- packages/workflow-core/src/lib/plugins/types.ts
- examples/headless-example/package.json
- apps/kyb-app/package.json
- sdks/workflow-node-sdk/package.json
- sdks/workflow-browser-sdk/CHANGELOG.md
- sdks/workflow-node-sdk/CHANGELOG.md
- services/workflows-service/CHANGELOG.md
- apps/backoffice-v2/package.json
- services/workflows-service/package.json
- examples/headless-example/CHANGELOG.md
- packages/workflow-core/src/lib/plugins/external-plugin/api-plugin/api-plugin-workflow-runner.test.ts
- apps/backoffice-v2/CHANGELOG.md
🧰 Additional context used
🪛 LanguageTool
packages/workflow-core/CHANGELOG.md
[uncategorized] ~7-~7: Did you mean “plugin”? If following ‘per’, nouns are often singular.
Context: ...ed pluginsInput with requestPayload per plugins & invokedAt now disablable ## 0.6.87 ...
(CONFUSION_OF_NNS_NN_UN)
🪛 Biome (1.9.4)
packages/workflow-core/src/lib/workflow-runner.ts
[error] 775-775: Unsafe usage of optional chaining.
If it short-circuits with 'undefined' the evaluation will throw TypeError here:
(lint/correctness/noUnsafeOptionalChaining)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (21)
apps/kyb-app/CHANGELOG.md (1)
3-7: LGTM! Changelog entry follows the conventional format.The new version entry properly documents the dependency update for @ballerine/workflow-browser-sdk.
sdks/workflow-browser-sdk/package.json (2)
4-4: LGTM! Version bump consistency maintained.The version bump from 0.6.87 to 0.6.88 is consistent between the package version and its
@ballerine/workflow-coredependency. This maintains version parity and aligns with the feature additions mentioned in the PR objectives.Also applies to: 37-37
4-4: Verify changelog entries for version 0.6.88.Please ensure that the changelog has been updated to document the new features:
- Addition of
pluginsInputin WorkflowRunner context- Updates to ApiPlugin and MerchantScreening plugin
- New
includeInvokedAtparameterpackages/workflow-core/src/lib/plugins/external-plugin/mastercard-merchant-screening-plugin.ts (2)
16-16: LGTM! Appropriate whitelisted properties.The whitelisted properties are correctly defined for merchant screening functionality.
32-35: Consistent error handling with improved debugging context.The error handling has been enhanced to consistently include the request payload across all error paths, which will help with debugging issues.
Also applies to: 109-112, 116-122, 131-131, 137-140
packages/workflow-core/src/lib/plugins/external-plugin/mastercard-merchant-screening-plugin.test.ts (1)
5-157: LGTM! Comprehensive test coverage.The test suite thoroughly covers:
- Plugin initialization with default properties
- Request payload inclusion in successful responses
- Request payload inclusion in failed responses
- Whitelisted property filtering
apps/backoffice-v2/src/lib/blocks/hooks/useMerchantScreeningBlock/columns.tsx (1)
126-145: LGTM! New column added for checked properties.The new column correctly implements the "Checked Properties" functionality as per PR objectives.
packages/workflow-core/src/lib/plugins/external-plugin/api-plugin/api-plugin.test.ts (5)
1-318: Great test coverage and organization!The test suite is well-structured with:
- Comprehensive coverage of core functionalities
- Clear test organization using describe blocks
- Proper handling of edge cases
- Effective use of mocks and specific assertions
11-48: LGTM! Well-structured basic invocation test.The test properly validates that
generateRequestPayloadFromWhitelistis called with the correct context.
50-147: LGTM! Comprehensive request payload testing.The test suite thoroughly covers various scenarios:
- Success case with status ok
- Failed requests
- Invalid responses
- Invalid requests
149-216: LGTM! Thorough invokedAt transformer testing.Tests properly verify the conditional inclusion of the invokedAt transformer based on the
includeInvokedAtflag.
218-316: LGTM! Well-structured whitelist testing.The test suite thoroughly covers the
generateRequestPayloadFromWhitelistfunctionality:
- Handling of whitelisted properties
- Nested object handling
- Array handling
- Default behavior when no whitelist is provided
packages/workflow-core/src/lib/plugins/external-plugin/api-plugin/api-plugin.ts (4)
40-41: LGTM! Well-typed property declarations.The new properties are properly typed and align with the plugin's functionality.
13-17: LGTM! Clear transformer definition.The
invokedAtTransformerDefinitionis well-defined with clear property mappings.
40-41: LGTM! Well-structured property additions.The new properties are properly typed and initialized with sensible defaults:
whitelistedInputPropertiesis optionalincludeInvokedAtdefaults to trueAlso applies to: 61-62
437-454: LGTM! Well-implemented whitelist generation.The
generateRequestPayloadFromWhitelistmethod:
- Handles the case when no whitelist is provided
- Properly processes nested objects
- Correctly handles undefined values
apps/backoffice-v2/src/lib/blocks/variants/DefaultBlocks/hooks/useDefaultBlocksLogic/useDefaultBlocksLogic.tsx (2)
472-473: LGTM! Clean integration of merchantScreeningInput.The integration of
pluginsInputdata into the merchant screening block is clean and follows the component's data flow pattern.
472-473: LGTM! Clean integration of merchant screening input.The addition of
merchantScreeningInputproperly utilizes the newpluginsInputdata structure with appropriate null coalescing.apps/backoffice-v2/src/lib/blocks/hooks/useMerchantScreeningBlock/useMerchantScreeningBlock.tsx (1)
21-21: LGTM! Clean integration of merchant screening input.The changes properly handle the new merchant screening input data with appropriate type safety and null checks.
Also applies to: 28-28, 78-78
packages/workflow-core/src/lib/plugins/external-plugin/individuals-sanctions-v2-plugin/individuals-sanctions-v2-plugin.test.ts (1)
11-11: LGTM! Improved test isolation.Adding
vi.clearAllMocks()ensures proper test isolation by clearing all mocks before each test run.apps/backoffice-v2/src/domains/workflows/fetchers.ts (1)
136-146: LGTM! Well-structured schema extension.The addition of
pluginsInputwith nestedmerchantScreeningfollows the existing schema patterns and properly handles optional fields.
.../workflow-core/src/lib/plugins/external-plugin/api-plugin/api-plugin-workflow-runner.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/workflow-core/CHANGELOG.md (2)
3-8: Enhance the changelog entry with more details.The current description "Updated workflow-core" is too vague. Consider providing specific details about what was updated to help users understand the changes better.
## 0.6.89 ### Patch Changes -Updated workflow-core +- Enhanced WorkflowRunner to include pluginsInput in context +- Updated ApiPlugin and MerchantScreening plugin to return requestPayload +- Added support for disabling invokedAt transformer
9-13: Improve changelog formatting and grammar.The current entry combines multiple changes in a single line and has some grammatical issues.
## 0.6.88 ### Patch Changes -Added pluginsInput with requestPayload per plugins & invokedAt now disablable +- Added pluginsInput with requestPayload per plugin +- Made invokedAt transformer optionally disabled🧰 Tools
🪛 LanguageTool
[uncategorized] ~13-~13: Did you mean “plugin”? If following ‘per’, nouns are often singular.
Context: ...ed pluginsInput with requestPayload per plugins & invokedAt now disablable ## 0.6.87 ...(CONFUSION_OF_NNS_NN_UN)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (15)
apps/backoffice-v2/CHANGELOG.md(1 hunks)apps/backoffice-v2/package.json(2 hunks)apps/kyb-app/CHANGELOG.md(1 hunks)apps/kyb-app/package.json(2 hunks)examples/headless-example/CHANGELOG.md(1 hunks)examples/headless-example/package.json(2 hunks)packages/workflow-core/CHANGELOG.md(1 hunks)packages/workflow-core/package.json(1 hunks)sdks/workflow-browser-sdk/CHANGELOG.md(1 hunks)sdks/workflow-browser-sdk/package.json(2 hunks)sdks/workflow-node-sdk/CHANGELOG.md(1 hunks)sdks/workflow-node-sdk/package.json(2 hunks)services/workflows-service/CHANGELOG.md(1 hunks)services/workflows-service/package.json(2 hunks)services/workflows-service/prisma/data-migrations(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (12)
- packages/workflow-core/package.json
- apps/kyb-app/CHANGELOG.md
- sdks/workflow-browser-sdk/CHANGELOG.md
- examples/headless-example/CHANGELOG.md
- sdks/workflow-node-sdk/package.json
- apps/kyb-app/package.json
- services/workflows-service/prisma/data-migrations
- sdks/workflow-node-sdk/CHANGELOG.md
- sdks/workflow-browser-sdk/package.json
- apps/backoffice-v2/package.json
- services/workflows-service/package.json
- examples/headless-example/package.json
🧰 Additional context used
🪛 LanguageTool
packages/workflow-core/CHANGELOG.md
[uncategorized] ~13-~13: Did you mean “plugin”? If following ‘per’, nouns are often singular.
Context: ...ed pluginsInput with requestPayload per plugins & invokedAt now disablable ## 0.6.87 ...
(CONFUSION_OF_NNS_NN_UN)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: Analyze (javascript)
- GitHub Check: test_windows
- GitHub Check: test_linux
- GitHub Check: build (windows-latest)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: lint
- GitHub Check: spell_check
🔇 Additional comments (2)
services/workflows-service/CHANGELOG.md (1)
3-18: LGTM! Consistent dependency updates.The changelog entries properly document the dependency updates to:
- @ballerine/[email protected]
- @ballerine/[email protected]
apps/backoffice-v2/CHANGELOG.md (1)
3-16: LGTM! Consistent dependency updates.The changelog entries properly document the dependency updates to:
- @ballerine/[email protected]
- @ballerine/[email protected]
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
apps/backoffice-v2/src/lib/blocks/variants/DefaultBlocks/hooks/useDefaultBlocksLogic/useDefaultBlocksLogic.tsx (2)
Line range hint
63-592: Consider breaking down the large hook into smaller, focused hooks.The
useDefaultBlocksLogichook is quite extensive and handles multiple responsibilities. Consider splitting it into smaller, more focused custom hooks for better maintainability and testability. For example:
useWorkflowDatafor workflow-related stateuseBlocksConfigurationfor blocks setupuseUserInteractionsfor user action handlers
506-507: Enhance error handling and type safety for merchantScreeningInput.Consider these improvements:
- Add runtime validation for the
requestPayloadstructure to catch potential issues early.- Define and use TypeScript interfaces for the payload shape.
- Consider logging when falling back to the empty object to help debug issues in production.
+interface MerchantScreeningPayload { + // Define expected payload structure +} + merchantScreeningInput: - workflow?.context?.pluginsInput?.merchantScreening?.requestPayload || {}, + (workflow?.context?.pluginsInput?.merchantScreening?.requestPayload as MerchantScreeningPayload) || (() => { + if (workflow?.context?.pluginsInput?.merchantScreening) { + console.warn('merchantScreening.requestPayload is missing or invalid'); + } + return {}; + })(),packages/workflow-core/src/lib/workflow-runner.ts (1)
815-819: Consider consolidating duplicate context merge logic.The code repeats the same context merge pattern for
pluginsInputin three different places. This could be refactored into a helper method to improve maintainability and reduce duplication.Consider applying this refactor:
+ private mergePluginInput(context: any, apiPlugin: HttpPlugin, requestPayload: any, status: ProcessStatus, error?: any) { + return this.mergeToContext( + context, + { requestPayload, status, ...(error ? { error } : {}) }, + `pluginsInput.${apiPlugin.name}`, + ); + } private async __invokeApiPlugin(apiPlugin: HttpPlugin, additionalContext?: AnyRecord) { // ... existing code ... if (apiPlugin.persistResponseDestination && responseBody) { this.context = this.mergeToContext( this.context, responseBody, apiPlugin.persistResponseDestination, ); - this.context = this.mergeToContext( - this.context, - { requestPayload, status: ProcessStatus.SUCCESS }, - `pluginsInput.${apiPlugin.name}`, - ); + this.context = this.mergePluginInput(this.context, apiPlugin, requestPayload, ProcessStatus.SUCCESS); } if (!apiPlugin.persistResponseDestination && responseBody) { this.context = this.mergeToContext( this.context, responseBody, `pluginsOutput.${apiPlugin.name}`, ); - this.context = this.mergeToContext( - this.context, - { requestPayload, status: ProcessStatus.SUCCESS }, - `pluginsInput.${apiPlugin.name}`, - ); + this.context = this.mergePluginInput(this.context, apiPlugin, requestPayload, ProcessStatus.SUCCESS); } if (error) { this.context = this.mergeToContext( this.context, { name: apiPlugin.name, error, status: ProcessStatus.ERROR }, `pluginsOutput.${apiPlugin.name}`, ); - this.context = this.mergeToContext( - this.context, - { requestPayload, error, status: ProcessStatus.ERROR }, - `pluginsInput.${apiPlugin.name}`, - ); + this.context = this.mergePluginInput(this.context, apiPlugin, requestPayload, ProcessStatus.ERROR, error); }Also applies to: 829-833, 843-847
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (23)
apps/backoffice-v2/CHANGELOG.md(1 hunks)apps/backoffice-v2/package.json(2 hunks)apps/backoffice-v2/src/domains/workflows/fetchers.ts(1 hunks)apps/backoffice-v2/src/lib/blocks/components/CallToActionLegacy/CallToActionLegacy.tsx(2 hunks)apps/backoffice-v2/src/lib/blocks/components/CallToActionLegacy/interfaces.ts(2 hunks)apps/backoffice-v2/src/lib/blocks/components/DirectorBlock/hooks/useDirectorBlock/useDirectorBlock.tsx(1 hunks)apps/backoffice-v2/src/lib/blocks/variants/DefaultBlocks/hooks/useDefaultBlocksLogic/useDefaultBlocksLogic.tsx(4 hunks)apps/kyb-app/CHANGELOG.md(1 hunks)apps/kyb-app/package.json(2 hunks)examples/headless-example/CHANGELOG.md(1 hunks)examples/headless-example/package.json(2 hunks)packages/common/CHANGELOG.md(1 hunks)packages/common/package.json(1 hunks)packages/workflow-core/CHANGELOG.md(1 hunks)packages/workflow-core/package.json(2 hunks)packages/workflow-core/src/lib/workflow-runner.ts(5 hunks)sdks/web-ui-sdk/CHANGELOG.md(1 hunks)sdks/web-ui-sdk/package.json(2 hunks)sdks/workflow-browser-sdk/CHANGELOG.md(1 hunks)sdks/workflow-browser-sdk/package.json(2 hunks)services/workflows-service/CHANGELOG.md(1 hunks)services/workflows-service/package.json(2 hunks)websites/docs/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- packages/common/package.json
- sdks/web-ui-sdk/CHANGELOG.md
- sdks/web-ui-sdk/package.json
- packages/common/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (11)
- apps/kyb-app/CHANGELOG.md
- sdks/workflow-browser-sdk/CHANGELOG.md
- packages/workflow-core/package.json
- apps/backoffice-v2/src/domains/workflows/fetchers.ts
- examples/headless-example/package.json
- apps/kyb-app/package.json
- examples/headless-example/CHANGELOG.md
- apps/backoffice-v2/package.json
- sdks/workflow-browser-sdk/package.json
- services/workflows-service/package.json
- services/workflows-service/CHANGELOG.md
🧰 Additional context used
🪛 Biome (1.9.4)
packages/workflow-core/src/lib/workflow-runner.ts
[error] 782-782: Unsafe usage of optional chaining.
If it short-circuits with 'undefined' the evaluation will throw TypeError here:
(lint/correctness/noUnsafeOptionalChaining)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: test_windows
- GitHub Check: test_linux
- GitHub Check: build (windows-latest)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: lint
- GitHub Check: spell_check
🔇 Additional comments (7)
packages/workflow-core/CHANGELOG.md (1)
3-10: LGTM! Changelog entry is well-formatted.The new version entry follows the conventional format and correctly documents the dependency updates.
apps/backoffice-v2/CHANGELOG.md (1)
3-11: LGTM! Changelog entry is well-formatted and consistent.The new version entry correctly documents all dependency updates with consistent version numbers across packages.
apps/backoffice-v2/src/lib/blocks/components/CallToActionLegacy/interfaces.ts (1)
9-9: LGTM! Interface changes maintain backward compatibility.The addition of optional
directorIdproperties is well-structured and maintains backward compatibility through the use of optional chaining (?).Also applies to: 24-24
apps/backoffice-v2/src/lib/blocks/components/CallToActionLegacy/CallToActionLegacy.tsx (1)
36-36: LGTM! Component changes align with interface updates.The component correctly implements the interface changes by:
- Destructuring the optional
directorIdfrom props- Passing it through to the
onReuploadNeededcallbackAlso applies to: 267-267
apps/backoffice-v2/src/lib/blocks/components/DirectorBlock/hooks/useDirectorBlock/useDirectorBlock.tsx (1)
192-192: LGTM! Hook changes complete the director ID propagation.The hook correctly propagates the director's ID to the reUploadNeededBlock, completing the chain of director ID handling from the interface through to the actual usage.
packages/workflow-core/src/lib/workflow-runner.ts (2)
782-782:⚠️ Potential issueFix unsafe optional chaining usage.
The optional chaining operator could lead to a TypeError if the method returns undefined and we try to destructure from it.
Apply this diff to handle the case when the method returns undefined:
- const { callbackAction, responseBody, requestPayload, error } = await apiPlugin.invoke?.( + const { callbackAction, responseBody, requestPayload, error } = (await apiPlugin.invoke?.( { ...this.context, workflowRuntimeConfig: this.#__config, workflowRuntimeId: this.#__runtimeId, }, additionalContext, - ); + )) ?? {};Likely invalid or redundant comment.
🧰 Tools
🪛 Biome (1.9.4)
[error] 782-782: Unsafe usage of optional chaining.
If it short-circuits with 'undefined' the evaluation will throw TypeError here:
(lint/correctness/noUnsafeOptionalChaining)
815-819: Verify the impact of storing request payloads in context.The addition of request payloads to the context could potentially increase memory usage if the payloads are large or numerous. Consider:
- Adding size limits for request payloads
- Implementing cleanup strategies for old plugin inputs
- Documenting the memory implications in comments
Run the following script to analyze the typical size of request payloads:
Also applies to: 829-833, 843-847
✅ Verification successful
Request payload storage is properly controlled and safe ✅
The codebase already implements multiple safeguards for request payload storage:
- Schema validation ensures payload structure and size constraints
- Whitelist filtering prevents storing unnecessary data
- Transformation pipeline allows fine-grained control over stored data
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Search for request payload definitions and usages to understand their typical structure and size # Test: Search for request payload definitions echo "Request payload definitions:" ast-grep --pattern 'interface $_ { requestPayload: $_; }' # Test: Search for request payload assignments echo "Request payload assignments:" rg -A 5 'requestPayload.*='Length of output: 14505
pluginsInputtocontextApiPlugin&MerchantScreeningplugin updated to returnrequestPayloadinvokedAttransformer now can be disabled viaincludeInvokedAtparameter.Checked Propertiesbutton to Mathc Results which renders request payload of Merchant Screening plugin.Full Json DatatoResultsaccording to designBack Office - Match Resutls
Back Office Checked Properties Dialog content
Summary by CodeRabbit
Based on the comprehensive summary, here are the updated release notes:
Dependency Updates
@ballerine/commonto version0.9.70@ballerine/workflow-browser-sdkto version0.6.89@ballerine/workflow-node-sdkto version0.6.89@ballerine/workflow-coreto version0.6.89New Features
pluginsInputsupport for pluginsinvokedAtfunctionalitymerchantScreeningInputdirectorIdsupport in relevant components and interfacesImprovements