Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed popup flickering in date picker & bump #2977

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

chesterkmr
Copy link
Collaborator

@chesterkmr chesterkmr commented Jan 20, 2025

  • Fixed issue when position of Date Picker popup was aligned to top left corner
  • Slightly reworked implementation of Date Picker (Needed for bugfix)
  • Ensured that data-testid is present on input
  • UI Bump

Summary by CodeRabbit

  • Dependency Updates

    • Updated @ballerine/ui from version 0.5.65 to 0.5.66 across multiple packages
    • Updated package versions for kyb-app and react-pdf-toolkit
  • Bug Fixes

    • Fixed flickering issue with Date Picker component popup
  • Improvements

    • Streamlined Date Picker input component with more flexible configuration

Copy link

changeset-bot bot commented Jan 20, 2025

⚠️ No Changeset found

Latest commit: 99bb76f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jan 20, 2025

Walkthrough

This pull request involves a series of version updates across multiple packages, primarily focusing on the @ballerine/ui dependency. The changes increment version numbers for the kyb-app, react-pdf-toolkit, and ui packages. The most notable modification is in the DatePickerInput component, which has been refactored to use more direct configuration for text field properties and focus handling.

Changes

File Change Summary
apps/kyb-app/CHANGELOG.md Added version 0.3.113, updating @ballerine/ui to 0.5.66
apps/kyb-app/package.json Updated package version to 0.3.113 and @ballerine/ui to 0.5.66
packages/react-pdf-toolkit/CHANGELOG.md Added version 1.2.66, updating @ballerine/ui to 0.5.66
packages/react-pdf-toolkit/package.json Updated package version to 1.2.66 and @ballerine/ui to 0.5.66
packages/ui/CHANGELOG.md Added version 0.5.66, fixing Date Picker component flickering
packages/ui/package.json Updated package version to 0.5.66
packages/ui/src/components/molecules/inputs/DatePickerInput/DatePickerInput.tsx Refactored DatePicker input handling and styling
services/workflows-service/prisma/data-migrations Updated subproject commit reference

Possibly related PRs

Suggested reviewers

  • alonp99
  • tomer-shvadron

Poem

🐰 Hop, hop, version update dance,
Dependencies twirl in a sweet romance,
UI components shine so bright,
Date Picker fixed with rabbit's might,
Changelog sings a version's chance! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/ui/src/components/molecules/inputs/DatePickerInput/DatePickerInput.tsx (1)

154-175: Consider adding ARIA attributes for better accessibility.

The TextField configuration is well-structured and comprehensive. However, consider enhancing accessibility by adding appropriate ARIA attributes.

Add aria-label or aria-labelledby to the textField configuration:

  textField: {
    size: 'small',
    fullWidth: true,
    className: ctw(
      'flex h-10 w-full rounded-md border border-input bg-background text-sm ring-offset-background file:border-0 file:bg-transparent file:text-sm file:font-medium placeholder:text-muted-foreground focus-visible:outline-none disabled:cursor-not-allowed disabled:opacity-50',
      '[&_.MuiOutlinedInput-notchedOutline]:border-none',
      '[&_.MuiOutlinedInput-root]:border',
      '[&_.MuiOutlinedInput-root]:border-input',
      '[&_.MuiOutlinedInput-root]:rounded-md',
      '[&_.MuiOutlinedInput-root.Mui-focused]:border-ring',
      '[&_.MuiOutlinedInput-root.Mui-focused]:ring-1',
      '[&_.MuiOutlinedInput-root.Mui-focused]:ring-ring',
      '[&_.MuiFormControl-root]:p-0',
      textInputClassName,
    ),
    inputProps: {
      'data-test-id': testId,
+     'aria-label': 'Date picker input',  // Or use a more specific label
    },
    InputProps: {
      className: 'focus:outline-none',
    },
  },
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 787713a and 99bb76f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (8)
  • apps/kyb-app/CHANGELOG.md (1 hunks)
  • apps/kyb-app/package.json (2 hunks)
  • packages/react-pdf-toolkit/CHANGELOG.md (1 hunks)
  • packages/react-pdf-toolkit/package.json (2 hunks)
  • packages/ui/CHANGELOG.md (1 hunks)
  • packages/ui/package.json (1 hunks)
  • packages/ui/src/components/molecules/inputs/DatePickerInput/DatePickerInput.tsx (5 hunks)
  • services/workflows-service/prisma/data-migrations (1 hunks)
✅ Files skipped from review due to trivial changes (6)
  • packages/react-pdf-toolkit/CHANGELOG.md
  • services/workflows-service/prisma/data-migrations
  • packages/ui/CHANGELOG.md
  • apps/kyb-app/package.json
  • packages/react-pdf-toolkit/package.json
  • packages/ui/package.json
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: test_windows
  • GitHub Check: build (windows-latest)
  • GitHub Check: test_linux
  • GitHub Check: build (ubuntu-latest)
  • GitHub Check: spell_check
  • GitHub Check: lint
🔇 Additional comments (4)
apps/kyb-app/CHANGELOG.md (1)

3-8: LGTM! The changelog entry is properly formatted.

The new version entry correctly documents the dependency update to @ballerine/[email protected] which contains the date picker flickering fix.

packages/ui/src/components/molecules/inputs/DatePickerInput/DatePickerInput.tsx (3)

39-39: LGTM! Good addition of focus event handling.

The new onFocus prop maintains consistency with the existing onBlur prop type and enhances component control.


51-51: LGTM! Proper prop handling.

The onFocus prop is correctly destructured and integrated into the component.


121-122: LGTM! Good implementation of focus handling and animation reduction.

The addition of focus event handlers and reduceAnimations prop should help resolve the popup flickering issue mentioned in the PR objectives.

@chesterkmr chesterkmr merged commit 5ce73dc into dev Jan 20, 2025
10 checks passed
@chesterkmr chesterkmr deleted the illiar/fix/date-picker-flickering branch January 20, 2025 13:03
Omri-Levy added a commit that referenced this pull request Jan 21, 2025
* feat: updated styles for link elements (#2959)

* feat: added csv document rendering (#2958)

* fix(monitoring): changes the block ordering in website credibility view (#2963)

* feat(monitoring): adds loading state for a single merchant record (BAL-3359) (#2960)

* feat(monitoring): adjusts merchant risk summary text (BAL-3373) (#2961)

* refactor(websiteCredibility): fix CardContent height for no data (#2966)

* refactor(websiteCredibility): fix CardContent height for no data

- Remove unused Tooltip import from recharts
- Update CardContent class to ensure full height

(your code is like a tidy room: looks clean but still has hidden messes)

* empty

* fix: UI fixes for statistics and merchant monitoring report pages (#2965)

* feat(monitoring): adds exhaustive check for action before deboarding a merchant (BAL-3343) (#2964)

* feat(monitoring): preserves scroll position on a data table (BAL-3248) (#2962)

* fix: chart graph cut off (BAL-3395) (#2969)

* fix: corrected home page merchants metrics source of truth (BAL-3396, BAL-3397) (#2968)

* chore(*): updated packages (#2971)

* fix(backoffice-v2): reverted default logic for from and to (#2973)

* refactor(entities): streamline form data context creation (#2974)

- Remove unnecessary context object creation
- Simplify the return statement by directly returning the new context

(your code is like a magic trick that turns objects into empty space)

* fix: remove monitoring params logic from navbar (#2975)

Co-authored-by: Omri Levy <[email protected]>

* fix: fixed popup flickering in date picker & bump (#2977)

* feat: add a report note when monitoring status is toggled (BAL-3398) (#2979)

* feat: add a report note when monitoring status is toggled

* chore: remove storing reason in metadata

* fix: dmt and dsta rules (#2970)

Co-authored-by: Lior Zamir <[email protected]>
Co-authored-by: Alon Peretz <[email protected]>

---------

Co-authored-by: Illia Rudniev <[email protected]>
Co-authored-by: Sasha <[email protected]>
Co-authored-by: Shane <[email protected]>
Co-authored-by: Tomer Shvadron <[email protected]>
Co-authored-by: liorzam <[email protected]>
Co-authored-by: Lior Zamir <[email protected]>
Co-authored-by: Alon Peretz <[email protected]>
@Omri-Levy Omri-Levy mentioned this pull request Jan 21, 2025
Omri-Levy added a commit that referenced this pull request Jan 21, 2025
* feat: updated styles for link elements (#2959)

* feat: added csv document rendering (#2958)

* fix(monitoring): changes the block ordering in website credibility view (#2963)

* feat(monitoring): adds loading state for a single merchant record (BAL-3359) (#2960)

* feat(monitoring): adjusts merchant risk summary text (BAL-3373) (#2961)

* refactor(websiteCredibility): fix CardContent height for no data (#2966)

* refactor(websiteCredibility): fix CardContent height for no data

- Remove unused Tooltip import from recharts
- Update CardContent class to ensure full height

(your code is like a tidy room: looks clean but still has hidden messes)

* empty

* fix: UI fixes for statistics and merchant monitoring report pages (#2965)

* feat(monitoring): adds exhaustive check for action before deboarding a merchant (BAL-3343) (#2964)

* feat(monitoring): preserves scroll position on a data table (BAL-3248) (#2962)

* fix: chart graph cut off (BAL-3395) (#2969)

* fix: corrected home page merchants metrics source of truth (BAL-3396, BAL-3397) (#2968)

* chore(*): updated packages (#2971)

* fix(backoffice-v2): reverted default logic for from and to (#2973)

* refactor(entities): streamline form data context creation (#2974)

- Remove unnecessary context object creation
- Simplify the return statement by directly returning the new context

(your code is like a magic trick that turns objects into empty space)

* fix: remove monitoring params logic from navbar (#2975)



* fix: fixed popup flickering in date picker & bump (#2977)

* feat: add a report note when monitoring status is toggled (BAL-3398) (#2979)

* feat: add a report note when monitoring status is toggled

* chore: remove storing reason in metadata

* fix: dmt and dsta rules (#2970)




---------

Co-authored-by: Illia Rudniev <[email protected]>
Co-authored-by: Sasha <[email protected]>
Co-authored-by: Shane <[email protected]>
Co-authored-by: Tomer Shvadron <[email protected]>
Co-authored-by: liorzam <[email protected]>
Co-authored-by: Lior Zamir <[email protected]>
Co-authored-by: Alon Peretz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants