fix: dmt and dsta rules #2970
fix: dmt and dsta rules #2970
Conversation
|
WalkthroughThis pull request introduces changes across multiple services in the workflows service, primarily focusing on refactoring array and parameter handling. The modifications involve using Lodash's Changes
Sequence DiagramsequenceDiagram
participant Service as DataAnalyticsService
participant Lodash as Lodash Utility
participant Method as Investigation Method
Service->>Lodash: Check array emptiness
Lodash-->>Service: Return emptiness status
Service->>Method: Apply filters conditionally
Method-->>Service: Process transaction data
Possibly related PRs
Suggested reviewers
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
services/workflows-service/src/data-analytics/data-investigation.service.ts (1)
281-307: Consider grouping related parameters together.The parameter organization could be improved by grouping related parameters. For example:
const { projectId, + // Transaction filters direction, transactionType, paymentMethods, excludePaymentMethods, + // Rule parameters ruleType, amountThreshold, } = options;Otherwise, the changes look good with proper array validation using
isEmpty.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
services/workflows-service/src/alert/alert.service.intg.test.ts(2 hunks)services/workflows-service/src/data-analytics/data-analytics.service.ts(3 hunks)services/workflows-service/src/data-analytics/data-investigation.service.ts(6 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: Analyze (javascript)
- GitHub Check: test_windows
- GitHub Check: test_linux
- GitHub Check: build (windows-latest)
- GitHub Check: lint
- GitHub Check: build (ubuntu-latest)
🔇 Additional comments (8)
services/workflows-service/src/data-analytics/data-investigation.service.ts (3)
20-20: LGTM!The import of
isEmptyfrom lodash is correctly placed.
171-186: LGTM! Improved array emptiness checks.The use of
isEmptyenhances the robustness of array validation for bothtransactionTypeandpaymentMethods.
212-212: LGTM! Consistent parameter handling.The removal of default values and use of
isEmptyaligns with the changes in other methods.Also applies to: 223-229
services/workflows-service/src/data-analytics/data-analytics.service.ts (3)
Line range hint
292-299: LGTM! Consistent array validation.The use of
isEmptyaligns with the changes in the investigation service.
490-492: LGTM! Consistent array validation.The use of
isEmptymaintains consistency with other methods.
Line range hint
816-824: LGTM! Consistent array validation.The use of
isEmptyfollows the established pattern.services/workflows-service/src/alert/alert.service.intg.test.ts (2)
85-86: LGTM! Valid ISO 8601 pattern.The regex pattern correctly validates ISO 8601 date-time strings.
2403-2418: LGTM! Comprehensive test assertions.The test properly validates the structure of
executionDetailsincluding the ISO date format.
* feat: updated styles for link elements (#2959) * feat: added csv document rendering (#2958) * fix(monitoring): changes the block ordering in website credibility view (#2963) * feat(monitoring): adds loading state for a single merchant record (BAL-3359) (#2960) * feat(monitoring): adjusts merchant risk summary text (BAL-3373) (#2961) * refactor(websiteCredibility): fix CardContent height for no data (#2966) * refactor(websiteCredibility): fix CardContent height for no data - Remove unused Tooltip import from recharts - Update CardContent class to ensure full height (your code is like a tidy room: looks clean but still has hidden messes) * empty * fix: UI fixes for statistics and merchant monitoring report pages (#2965) * feat(monitoring): adds exhaustive check for action before deboarding a merchant (BAL-3343) (#2964) * feat(monitoring): preserves scroll position on a data table (BAL-3248) (#2962) * fix: chart graph cut off (BAL-3395) (#2969) * fix: corrected home page merchants metrics source of truth (BAL-3396, BAL-3397) (#2968) * chore(*): updated packages (#2971) * fix(backoffice-v2): reverted default logic for from and to (#2973) * refactor(entities): streamline form data context creation (#2974) - Remove unnecessary context object creation - Simplify the return statement by directly returning the new context (your code is like a magic trick that turns objects into empty space) * fix: remove monitoring params logic from navbar (#2975) Co-authored-by: Omri Levy <[email protected]> * fix: fixed popup flickering in date picker & bump (#2977) * feat: add a report note when monitoring status is toggled (BAL-3398) (#2979) * feat: add a report note when monitoring status is toggled * chore: remove storing reason in metadata * fix: dmt and dsta rules (#2970) Co-authored-by: Lior Zamir <[email protected]> Co-authored-by: Alon Peretz <[email protected]> --------- Co-authored-by: Illia Rudniev <[email protected]> Co-authored-by: Sasha <[email protected]> Co-authored-by: Shane <[email protected]> Co-authored-by: Tomer Shvadron <[email protected]> Co-authored-by: liorzam <[email protected]> Co-authored-by: Lior Zamir <[email protected]> Co-authored-by: Alon Peretz <[email protected]>
* feat: updated styles for link elements (#2959) * feat: added csv document rendering (#2958) * fix(monitoring): changes the block ordering in website credibility view (#2963) * feat(monitoring): adds loading state for a single merchant record (BAL-3359) (#2960) * feat(monitoring): adjusts merchant risk summary text (BAL-3373) (#2961) * refactor(websiteCredibility): fix CardContent height for no data (#2966) * refactor(websiteCredibility): fix CardContent height for no data - Remove unused Tooltip import from recharts - Update CardContent class to ensure full height (your code is like a tidy room: looks clean but still has hidden messes) * empty * fix: UI fixes for statistics and merchant monitoring report pages (#2965) * feat(monitoring): adds exhaustive check for action before deboarding a merchant (BAL-3343) (#2964) * feat(monitoring): preserves scroll position on a data table (BAL-3248) (#2962) * fix: chart graph cut off (BAL-3395) (#2969) * fix: corrected home page merchants metrics source of truth (BAL-3396, BAL-3397) (#2968) * chore(*): updated packages (#2971) * fix(backoffice-v2): reverted default logic for from and to (#2973) * refactor(entities): streamline form data context creation (#2974) - Remove unnecessary context object creation - Simplify the return statement by directly returning the new context (your code is like a magic trick that turns objects into empty space) * fix: remove monitoring params logic from navbar (#2975) * fix: fixed popup flickering in date picker & bump (#2977) * feat: add a report note when monitoring status is toggled (BAL-3398) (#2979) * feat: add a report note when monitoring status is toggled * chore: remove storing reason in metadata * fix: dmt and dsta rules (#2970) --------- Co-authored-by: Illia Rudniev <[email protected]> Co-authored-by: Sasha <[email protected]> Co-authored-by: Shane <[email protected]> Co-authored-by: Tomer Shvadron <[email protected]> Co-authored-by: liorzam <[email protected]> Co-authored-by: Lior Zamir <[email protected]> Co-authored-by: Alon Peretz <[email protected]>
Summary by CodeRabbit
New Features
Refactor
isEmptyfunction from lodashBug Fixes