fix: chart graph cut off (BAL-3395)

[r4zendev]

Summary by CodeRabbit

• New Features

  • Enhanced website credibility component with trend indicators
  • Added visual representation of traffic source trends
  • Implemented dynamic chart scaling based on monthly visit data
  • Introduced trend direction and percentage change display

• Improvements

  • Refined data handling for traffic sources
  • Improved analytical capabilities of the component

[changeset-bot]

⚠️ No Changeset found

Latest commit: f7d40bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Warning

Rate limit exceeded

@r4zendev has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 59 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 6931be4 and f7d40bf.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (7)

• apps/kyb-app/CHANGELOG.md (1 hunks)
• apps/kyb-app/package.json (2 hunks)
• packages/react-pdf-toolkit/CHANGELOG.md (1 hunks)
• packages/react-pdf-toolkit/package.json (2 hunks)
• packages/ui/CHANGELOG.md (1 hunks)
• packages/ui/package.json (1 hunks)
• packages/ui/src/components/templates/report/components/WebsiteCredibility/WebsiteCredibility.tsx (5 hunks)

Walkthrough

The pull request modifies the WebsiteCredibility component in the UI package, focusing on improving data processing and visualization. The changes include refactoring traffic source handling, calculating Y-axis ticks for the area chart, and adding a new CardFooter to display trend indicators. The component now more accurately represents traffic data and provides trend information for monthly visits, enhancing the overall analytical presentation.

Changes

File	Change Summary
packages/ui/src/components/templates/report/components/WebsiteCredibility/WebsiteCredibility.tsx	- Added imports for TrendingDown and TrendingUp icons - Refactored traffic sources processing logic - Implemented Y-axis tick calculation based on monthly visit indicators - Added CardFooter with trend direction and percentage change

Sequence Diagram

sequenceDiagram
    participant Component as WebsiteCredibility
    participant DataProcessor as Data Processing
    participant Chart as Area Chart
    participant Footer as Card Footer

    Component->>DataProcessor: Process traffic sources
    DataProcessor-->>Component: Processed sources
    Component->>Chart: Calculate Y-axis ticks
    Chart-->>Component: Render chart
    Component->>Footer: Calculate trend
    Footer-->>Component: Display trend indicators

Loading

Possibly related PRs

• Fixed website credibility mapping #2465: Modifies text display for empty states in WebsiteCredibility component
• Fix traffic empty state display #2953: Addresses display of empty states in WebsiteCredibility
• refactor(websiteCredibility): fix CardContent height for no data #2966: Refactors component to fix CardContent height for empty data scenarios

Suggested reviewers

• Omri-Levy

Poem

🐰 A rabbit's tale of data's grace,
Trends dancing with a charted embrace,
Icons rising, falling with might,
WebsiteCredibility shining bright,
Code hopping with analytical flair! 📊🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (2)

packages/ui/src/components/templates/report/components/WebsiteCredibility/WebsiteCredibility.tsx (2)

100-116: Optimize visitors calculation using array methods.

The current implementation can be more concise and potentially more performant using array methods.

Consider this optimization:

-let minVisitors = 0;
-let maxVisitors = 0;
-
-trafficAnalysis.montlyVisitsIndicators.forEach(({ value }) => {
-  const num = parseInt(value);
-
-  if (num < minVisitors) {
-    minVisitors = num;
-  }
-
-  if (num > maxVisitors) {
-    maxVisitors = num;
-  }
-});
-
-const visitorsTotalArea = maxVisitors - minVisitors;
+const numbers = trafficAnalysis.montlyVisitsIndicators.map(({ value }) => parseInt(value));
+const minVisitors = Math.min(...numbers);
+const maxVisitors = Math.max(...numbers);
+const visitorsTotalArea = maxVisitors - minVisitors;

---

302-321: Enhance trend percentage formatting.

Consider using dynamic decimal places for better readability. Small changes might benefit from more precision, while large changes could be rounded.

-`${trend.percentage.toFixed(1)}%`
+`${trend.percentage < 1 
+  ? trend.percentage.toFixed(2) 
+  : trend.percentage < 10 
+    ? trend.percentage.toFixed(1) 
+    : Math.round(trend.percentage)}%`

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8630d3 and 6931be4.

📒 Files selected for processing (1)

• packages/ui/src/components/templates/report/components/WebsiteCredibility/WebsiteCredibility.tsx (5 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

packages/ui/src/components/templates/report/components/WebsiteCredibility/WebsiteCredibility.tsx (1)

87-95: Add validation for negative remainder.

The remainder calculation could potentially result in a negative value if the sum of traffic sources exceeds 100%. This edge case should be handled to maintain data integrity.

Consider adding validation:

 const remainder = 100 - values.reduce((acc, item) => acc + item.value, 0);
+if (remainder < 0) {
+  console.warn('Traffic sources sum exceeds 100%');
+  return values;
+}