feat(monitoring): adds loading state for a single merchant record (BAL-3359)

[r4zendev]

Summary by CodeRabbit

• New Features

  • Added loading skeletons to the Merchant Monitoring Business Report page
  • Improved user experience by providing visual feedback during data fetching

• Chores

  • Updated subproject commit in workflows service data migrations

[changeset-bot]

⚠️ No Changeset found

Latest commit: 98da629

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The pull request introduces a loading state for the MerchantMonitoringBusinessReport component by adding Skeleton components and a new isFetchingBusinessReport variable. This enhancement provides visual feedback during data fetching, improving the user interface's responsiveness. The changes modify the useMerchantMonitoringBusinessReportLogic hook to expose the fetching state and update the component's rendering logic to conditionally display loading skeletons when data is being retrieved.

Changes

File	Change Summary
apps/backoffice-v2/src/pages/MerchantMonitoringBusinessReport/MerchantMonitoringBusinessReport.page.tsx	Added isFetchingBusinessReport to control skeleton loading state
apps/backoffice-v2/src/pages/MerchantMonitoringBusinessReport/hooks/useMerchantMonitoringBusinessReportLogic/useMerchantMonitoringBusinessReportLogic.tsx	Updated hook to return isFetchingBusinessReport from query
services/workflows-service/prisma/data-migrations	Subproject commit hash updated

Sequence Diagram

sequenceDiagram
    participant Component as MerchantMonitoringBusinessReport
    participant Hook as useMerchantMonitoringBusinessReportLogic
    participant Query as useBusinessReportByIdQuery

    Component->>Hook: Request data
    Hook->>Query: Fetch business report
    Query-->>Hook: Return data and fetching state
    Hook-->>Component: Provide isFetchingBusinessReport
    alt Is Fetching
        Component->>Component: Render Skeleton
    else Data Loaded
        Component->>Component: Render Actual Content
    end

Loading

Possibly related PRs

• Fixed websites company tab data #2449: Modifies MerchantMonitoringBusinessReport component prop
• Fixed reports #2454: Changes to report-adapter.ts file
• Removed risk score from UI elements #2491: Updates to BusinessReportSummary component

Suggested reviewers

• Omri-Levy
• MatanYadaev

Poem

🐰 Loading bunnies hop and sway,
Skeletons dance their merry way
Data streams in, smooth and bright
Merchant reports now shine with light!
A loading state, so sleek and neat 🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[alonp99]

@r4zendev can you do something with the black tag near the status? 🙏

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

apps/backoffice-v2/src/pages/MerchantMonitoringBusinessReport/MerchantMonitoringBusinessReport.page.tsx (3)

90-96: Consider adjusting the skeleton dimensions.

The fixed width of the skeleton (w-32) might be too narrow for longer website names, causing a jarring transition when the actual content loads.

Consider using a wider skeleton or matching the parent width:

-            <Skeleton className="h-6 w-32" />
+            <Skeleton className="h-6 w-64" />

---

97-139: Enhance loading state granularity.

Currently, a single skeleton represents multiple status elements. Consider showing individual skeletons for each element to provide a more accurate loading representation.

Here's a suggested improvement:

-            <Skeleton className="my-6 h-6 w-2/3" />
+            <div className="flex items-center space-x-8 pb-4">
+              <Skeleton className="h-6 w-24" /> {/* Status */}
+              <Skeleton className="h-6 w-48" /> {/* Created at */}
+              <Skeleton className="h-6 w-32" /> {/* Monitoring Status */}
+              <Skeleton className="h-6 w-16" /> {/* Notes */}
+            </div>

---

155-172: LGTM! Well-structured content loading state.

The implementation provides a good visual representation of the tab content structure. However, consider making the skeleton heights dynamic based on viewport height for better responsiveness.

Consider using viewport-relative units:

-                  <div className="mt-6 flex h-[24rem] w-full flex-nowrap gap-8">
+                  <div className="mt-6 flex h-[40vh] w-full flex-nowrap gap-8">

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 01c2c7b and 10bca58.

📒 Files selected for processing (3)

• apps/backoffice-v2/src/pages/MerchantMonitoringBusinessReport/MerchantMonitoringBusinessReport.page.tsx (4 hunks)
• apps/backoffice-v2/src/pages/MerchantMonitoringBusinessReport/hooks/useMerchantMonitoringBusinessReportLogic/useMerchantMonitoringBusinessReportLogic.tsx (2 hunks)
• services/workflows-service/prisma/data-migrations (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• services/workflows-service/prisma/data-migrations

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: test_windows
• GitHub Check: test_linux
• GitHub Check: build (windows-latest)
• GitHub Check: Analyze (javascript)
• GitHub Check: build (ubuntu-latest)
• GitHub Check: lint

🔇 Additional comments (3)

apps/backoffice-v2/src/pages/MerchantMonitoringBusinessReport/hooks/useMerchantMonitoringBusinessReportLogic/useMerchantMonitoringBusinessReportLogic.tsx (1)

27-29: LGTM! Clean implementation of loading state.

The changes correctly expose the loading state from React Query, with consistent naming conventions.

Also applies to: 111-111

apps/backoffice-v2/src/pages/MerchantMonitoringBusinessReport/MerchantMonitoringBusinessReport.page.tsx (2)

12-12: LGTM! Clean setup for loading states.

The Skeleton component is properly imported and the loading state is correctly destructured from the hook.

Also applies to: 41-41

---

103-119: Addressing PR comment about the black tag near status.

The implementation now includes proper styling for the status badge with appropriate background colors and text colors. The loading state ensures a smooth transition when the status loads.