Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implemented priority fields & bug fixes & tests #2950

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat: implemented priority fields & bug fixes & tests #2950

merged 1 commit into from
Jan 9, 2025

Conversation

chesterkmr
Copy link
Collaborator

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: 0dfcc1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 9, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Finishing Touches

  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@chesterkmr chesterkmr merged commit be4e1b6 into bal-3137 Jan 9, 2025
1 check passed
@chesterkmr chesterkmr deleted the bal-3332 branch January 9, 2025 12:49
chesterkmr added a commit that referenced this pull request Jan 28, 2025
@chesterkmr @alonp99 @r4zendev
Bal 3478 (#2993)
d6f7267 
* feat: added initial validator boilerplate & utilities & tests

* feat: implmeneted validate method & tests

* fix: test

* feat: implemented conditional validation rule apply & custom validators

* feat: implemented useValidate & tests

* feat: finalized validator component

* feat: added story for validator

* feat: added renderer & tests & dynamic form boilerplate

* feat: added rule engine

* feat: implemented dynamic form context logic & tests & types

* feat: finalized core form logic & finalized field list & tests

* fix: tests

* fix: build

* feat: added input boilerplates(unfinished) & field layout & tests

* feat: added fields (wip)

* fix: fixed build & tests

* feat: implemented events & fixed tests

* feat: implemented fields extend & removed elementsMap

* feat: added select field & fixed types & tests

* feat: added initial demo & bugfixes & updated tests

* feat: added phone field & tests & updated storybook

* feat: added file field & added tests & minor fixes

* feat: added clear value on input hide & updates tests

* feat: fixed onMount & onUnmount events & updated tests

* feat: added configurable file upload

* feat: added task runner & tests

* feat: implemented file upload on submit & tests

* feat: added more form stories & tests update

* feat: added custom validators & custom inputs examples

* feat: added radio field & tests

* feat: added tags input & tests & config fixes

* feat: added v2 adapters for custom fields & updated exports from ui & added tests (#2913)

* feat: added field descriptions & updated tests (#2914)

* feat: reworked ui elements for v2 & added tests (#2930)

* feat: reworked ui elements for v2 & added tests

* feat: added validate on blur

* feat: added initial rendering of UI V2

* feat: updated exports

* feat: implemented events provider

* feat: updated exports

* fix: listeners reinitialize

* feat: implemented document field

* feat: added document validator

* fix: fixed types

* fix: fixed tests & typo

* fix: fixed touched issue with non field definitions in form

* fix: updated validation params & cleanup

* fix: better violation names on statistics page (BAL-3294) (#2932)

* feat: better violation names on statistics page

* fix: CodeRabbit comments

---------

Co-authored-by: Alon Peretz <[email protected]>

* fix: renamed property in applyWhen rule

* feat: added url format & refactor

* Bal 3242 (#2939)

* feat: fixed types & exports & verbose logging & submit event

* feat: implemented plugins runner

* feat: updated types & minor adjustments to format string

* fix: document validator fixes & updated metadata

* feat: added submit button lock while tasks running

* feat: added metadata to useField & useElement & added missing format validator

* feat: added ref to form & fixed types & tests

* fix: fixed plugins context update & added plugin listeners

* feat: updated en translations

* fix: fixed kyb tests

* Bal 2977 (#2942)

* fix: css fixes & rule engine fixes

* feat: implemented sync

* feat: added classnames to row & column

* fix: submit button styles

* Bal 3330 (#2949)

* feat: added formatting for rules & updated tests

* feat: added transformer plugin

* fix: lock file

* feat: implemented priority fields & bug fixes & tests (#2950)

* fix: fixed build

* feat: implemented default data insertion on field list (#2951)

* feat: added support of html tags in descriptions

* feat: added useControl hook

* fix: reworked revision

* fix: fixed renderer stories

* Bal 3356 (WIP) (#2967)

* feat: implemented document field in ui package

* feat: finalized documentfield

* fix: fixed build

* fix: cleanup

* fix: fixed fieldlist

* feat: updated tests

* feat: added clear value for edge cases as documents

* fix: fixed tests & plugins

* fix: fixed fields extraction from definition

* fix: fixed infinite call of useRules due to default array value

* feat: enabled sync rules execution for controls disable and elements hiding

* feat: reworked cleanup

* feat: updated tests

* fix: added handling of dynamic indexes for useRquired & bugfixes

* fix: fixed types

* feat: added version to ui definition & added version resolving to kyb

* feat: reorganize

* feat: removed v1

* fix: post merge fixes & tests & reorganized folders

* fix: fixed state step tracking on submit

* fix: state sync fix

* fix: fixed tests

* feat: ui bump

* fix: fixed bug where dynamic indexes was not resolved in validation

* fix: bugfixes

* fix: cleanup

---------

Co-authored-by: Alon Peretz <[email protected]>
Co-authored-by: Sasha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chesterkmr