Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scrollable home page image of a partner website (BAL-3283) #2926

Merged
merged 3 commits into from
Jan 1, 2025

Conversation

r4zendev
Copy link
Collaborator

@r4zendev r4zendev commented Jan 1, 2025

Changes

  • Adds an ability to scroll the partner's website directly on the merchant report page

Summary by CodeRabbit

  • New Features

    • Added scrollable view feature for partner website in UI package
  • Dependency Updates

    • Updated @ballerine/ui from version 0.5.57 to 0.5.58 across multiple packages
    • Updated @ballerine/kyb-app version from 0.3.103 to 0.3.104
    • Updated @ballerine/react-pdf-toolkit version from 1.2.57 to 1.2.58
  • UI Improvements

    • Enhanced homepage screenshot display with improved layout and accessibility

@r4zendev r4zendev self-assigned this Jan 1, 2025
Copy link

changeset-bot bot commented Jan 1, 2025

⚠️ No Changeset found

Latest commit: 01ad92f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jan 1, 2025

Walkthrough

This pull request involves version updates across multiple packages within the Ballerine ecosystem. The primary focus is updating the @ballerine/ui package from version 0.5.57 to 0.5.58, which introduces a scrollable view feature for the partner website. Corresponding version increments have been made in the kyb-app and react-pdf-toolkit packages to reflect this dependency update. Additionally, the BusinessReportSummary component in the UI package has been modified to improve the homepage screenshot rendering.

Changes

File Change Summary
apps/kyb-app/CHANGELOG.md Added version 0.3.104 with @ballerine/[email protected] update
apps/kyb-app/package.json Updated version to 0.3.104 and @ballerine/ui to 0.5.58
packages/react-pdf-toolkit/CHANGELOG.md Added version 1.2.58 with @ballerine/[email protected] update
packages/react-pdf-toolkit/package.json Updated version to 1.2.58 and @ballerine/ui to 0.5.58
packages/ui/CHANGELOG.md Added version 0.5.58 with scrollable view feature
packages/ui/package.json Updated version to 0.5.58
packages/ui/src/components/templates/report/components/BusinessReportSummary/BusinessReportSummary.tsx Modified homepage screenshot rendering with improved layout and text

Possibly related PRs

Suggested Reviewers

  • alonp99
  • tomer-shvadron

Poem

🐰 Hop, hop, version update's here!
Scrolling views now crystal clear
UI dancing, packages align
Ballerine's code continues to shine
A rabbit's code review delight! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
packages/ui/src/components/templates/report/components/BusinessReportSummary/BusinessReportSummary.tsx (2)

77-77: Ensure fallback logic is robust when homepageScreenshotUrl is missing.
Though the conditional check avoids rendering the card, consider adding a fallback or placeholder UI in scenarios where the screenshot is unavailable, especially if end-users might expect a screenshot.


80-101: Consider accessibility enhancements for image and link usage.

  1. You already have a descriptive alt text. However, you might also consider an aria-label on the anchor for screen readers, especially since it allows scrolling to access web content.
  2. The overlay text could potentially conflict with the screenshot. If it’s critical for accessibility or user guidance, consider ensuring it’s programmatically accessible too, such as by adding an aria-live region or descriptive aria-label.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8fabbc9 and 01ad92f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (7)
  • apps/kyb-app/CHANGELOG.md (1 hunks)
  • apps/kyb-app/package.json (2 hunks)
  • packages/react-pdf-toolkit/CHANGELOG.md (1 hunks)
  • packages/react-pdf-toolkit/package.json (2 hunks)
  • packages/ui/CHANGELOG.md (1 hunks)
  • packages/ui/package.json (1 hunks)
  • packages/ui/src/components/templates/report/components/BusinessReportSummary/BusinessReportSummary.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (5)
  • packages/ui/package.json
  • packages/react-pdf-toolkit/package.json
  • apps/kyb-app/package.json
  • packages/react-pdf-toolkit/CHANGELOG.md
  • apps/kyb-app/CHANGELOG.md
🔇 Additional comments (1)
packages/ui/CHANGELOG.md (1)

3-7: Great job documenting the new scrollable feature.
The changelog succinctly describes the addition. This helps maintain a clear record for future reference.

@r4zendev r4zendev merged commit 905d518 into dev Jan 1, 2025
10 checks passed
@r4zendev r4zendev deleted the bal3283 branch January 1, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants