-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: scrollable home page image of a partner website (BAL-3283) #2926
Conversation
|
WalkthroughThis pull request involves version updates across multiple packages within the Ballerine ecosystem. The primary focus is updating the Changes
Possibly related PRs
Suggested Reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/ui/src/components/templates/report/components/BusinessReportSummary/BusinessReportSummary.tsx (2)
77-77
: Ensure fallback logic is robust whenhomepageScreenshotUrl
is missing.
Though the conditional check avoids rendering the card, consider adding a fallback or placeholder UI in scenarios where the screenshot is unavailable, especially if end-users might expect a screenshot.
80-101
: Consider accessibility enhancements for image and link usage.
- You already have a descriptive
alt
text. However, you might also consider anaria-label
on the anchor for screen readers, especially since it allows scrolling to access web content.- The overlay text could potentially conflict with the screenshot. If it’s critical for accessibility or user guidance, consider ensuring it’s programmatically accessible too, such as by adding an
aria-live
region or descriptivearia-label
.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (7)
apps/kyb-app/CHANGELOG.md
(1 hunks)apps/kyb-app/package.json
(2 hunks)packages/react-pdf-toolkit/CHANGELOG.md
(1 hunks)packages/react-pdf-toolkit/package.json
(2 hunks)packages/ui/CHANGELOG.md
(1 hunks)packages/ui/package.json
(1 hunks)packages/ui/src/components/templates/report/components/BusinessReportSummary/BusinessReportSummary.tsx
(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- packages/ui/package.json
- packages/react-pdf-toolkit/package.json
- apps/kyb-app/package.json
- packages/react-pdf-toolkit/CHANGELOG.md
- apps/kyb-app/CHANGELOG.md
🔇 Additional comments (1)
packages/ui/CHANGELOG.md (1)
3-7
: Great job documenting the new scrollable feature.
The changelog succinctly describes the addition. This helps maintain a clear record for future reference.
Changes
Summary by CodeRabbit
New Features
Dependency Updates
@ballerine/ui
from version 0.5.57 to 0.5.58 across multiple packages@ballerine/kyb-app
version from 0.3.103 to 0.3.104@ballerine/react-pdf-toolkit
version from 1.2.57 to 1.2.58UI Improvements