Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed gender from add ubo flow #2924

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Removed gender from add ubo flow #2924

merged 1 commit into from
Jan 1, 2025

Conversation

Omri-Levy
Copy link
Contributor

@Omri-Levy Omri-Levy commented Jan 1, 2025

Summary by CodeRabbit

  • Form Configuration

    • Removed gender input field from the UBO (Ultimate Beneficial Owner) form
    • Reduced required form fields from ten to nine
  • Data Processing

    • Updated UBO creation workflow to remove gender property from entity adapter

Copy link

changeset-bot bot commented Jan 1, 2025

⚠️ No Changeset found

Latest commit: 3b3ec6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jan 1, 2025

Walkthrough

The pull request involves removing the gender input field from the UBO (Ultimate Beneficial Owner) form definition and related service method. Specifically, the changes delete the company-ownership-gender-input from the form's JSON definition in the backoffice application and remove the corresponding gender property from the UBO entity adapter in the workflows service. This modification reduces the required fields in the form from ten to nine and simplifies the data structure for UBO creation.

Changes

File Change Summary
apps/backoffice-v2/src/lib/blocks/hooks/useManageUbosBlock/ubos-form-json-definition.ts Removed company-ownership-gender-input from elements and required arrays in ubosFormJsonDefinition
services/workflows-service/src/case-management/case-management.service.ts Removed gender property from uboToEntityAdapter function in createUbo method

Possibly related PRs

Suggested Reviewers

  • tomer-shvadron
  • MatanYadaev

Poem

🐰 A Rabbit's Ode to Simplified Forms 🐰

Gender field, oh gender field, you're gone today
From UBO forms, you've slipped away
Nine fields remain, lean and bright
Simplicity now takes its flight!

Hop hop hooray! 🎉


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4f9f7d and 3b3ec6b.

📒 Files selected for processing (2)
  • apps/backoffice-v2/src/lib/blocks/hooks/useManageUbosBlock/ubos-form-json-definition.ts (0 hunks)
  • services/workflows-service/src/case-management/case-management.service.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • services/workflows-service/src/case-management/case-management.service.ts
  • apps/backoffice-v2/src/lib/blocks/hooks/useManageUbosBlock/ubos-form-json-definition.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Omri-Levy Omri-Levy enabled auto-merge (squash) January 1, 2025 09:42
@Omri-Levy Omri-Levy merged commit eac68e8 into dev Jan 1, 2025
10 checks passed
@Omri-Levy Omri-Levy deleted the bal-3293 branch January 1, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants