fix: eslint broken in vscode #2920
Conversation
|
WalkthroughThis pull request focuses on standardizing ESLint configuration across multiple projects and packages. The changes primarily involve updating the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (10)
✅ Files skipped from review due to trivial changes (1)
🔇 Additional comments (10)packages/common/.eslintrc.cjs (1)
Updating the ✅ Verification successfulESLint configuration appears to be correctly set up The verification shows that:
The TypeScript project references are correctly configured, and ESLint should be able to properly resolve and use the TypeScript configuration. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Verify that ESLint is able to load the 'tsconfig.eslint.json' from the current directory
eslint --print-config . | grep 'tsconfig'
Length of output: 138 Script: #!/bin/bash
# Check if tsconfig.eslint.json exists in the expected location
fd -t f "tsconfig.eslint.json" packages/common/
# Check the content of tsconfig.eslint.json if it exists
fd -t f "tsconfig.eslint.json" packages/common/ -x cat {}
# Check the content of .eslintrc.cjs to verify the complete configuration
cat packages/common/.eslintrc.cjs
Length of output: 459 Script: #!/bin/bash
# Check if the base tsconfig.json exists and its content
fd -t f "tsconfig.json" packages/common/ -x cat {}
# Check if there are any TypeScript files in the specified include paths
fd -e ts "." packages/common/src/
fd -t f "rollup.config.ts" packages/common/
Length of output: 7839 apps/kyb-app/.eslintrc.cjs (1)
The addition of apps/workflows-dashboard/.eslintrc.cjs (1)
Adopting packages/blocks/.eslintrc.cjs (1)
Setting sdks/workflow-browser-sdk/.eslintrc.cjs (2)
✅ Verification successfulTypeScript configuration file is correctly referenced The verification confirms that 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify that tsconfig.eslint.json is present in sdks/workflow-browser-sdk
fd tsconfig.eslint.json --exact-depth 1 --glob --base-directory=sdks/workflow-browser-sdk
Length of output: 112 packages/workflow-core/.eslintrc.cjs (1)
sdks/web-ui-sdk/.eslintrc.cjs (1)
packages/ui/.eslintrc.cjs (1)
apps/backoffice-v2/.eslintrc.cjs (1)
This change to use You can run this script to locate all instances of ✅ Verification successfulESLint configuration is properly set up with the correct tsconfig files The verification shows that:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Search for 'tsconfig.eslint.json' across the repository,
# and display surrounding lines to gauge usage context.
fd 'tsconfig.eslint.json' --exec rg -A 3 -B 3 'tsconfig.eslint.json' {}
Length of output: 71 Script: #!/bin/bash
# Let's first check if the file exists in the specified directory
ls -la apps/backoffice-v2/tsconfig.eslint.json
# Also check for any tsconfig files in that directory to see alternatives
ls -la apps/backoffice-v2/tsconfig*
# Let's also check the content of .eslintrc.cjs to understand the full context
cat apps/backoffice-v2/.eslintrc.cjs
Length of output: 842 Script: #!/bin/bash
# Let's check the content of the tsconfig.eslint.json to ensure it's properly configured
cat apps/backoffice-v2/tsconfig.eslint.json
# Also check the main tsconfig.json for comparison
cat apps/backoffice-v2/tsconfig.json
Length of output: 438 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This PR fixes an issue related to VSCode ESLint extension that prevents it from detecting tsconfig in appropriate directory unless base directory is specified and makes it unable to detect eslintignore files outside root directory of the workspace.
Summary by CodeRabbit
.eslintignoreto exclude specific directories and configuration files from linting