-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): bump versions and update dependencies #2908
Conversation
- Update version for backoffice-v2 to 0.7.83 and kyb-app to 0.3.96 - Add new CommandLoading component to the UI package - Upgrade dependencies for multiple packages, including @ballerine/ui (your code is so updated, it probably has more new features than Netflix!)
|
WalkthroughThis pull request introduces minor updates across multiple packages in the Ballerine ecosystem. The changes primarily focus on version increments and dependency updates, with a notable addition of a Changes
Suggested reviewers
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/backoffice-v2/src/common/components/atoms/MultiSelect/MultiSelect.tsx (1)
123-129
: Condensed Loading vs. Empty States
Conditionally renderingCommandLoading
versusCommandEmpty
is clear. Ensure any intermediate states or partial results are also handled if applicable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (13)
apps/backoffice-v2/CHANGELOG.md
(1 hunks)apps/backoffice-v2/package.json
(2 hunks)apps/backoffice-v2/src/common/components/atoms/MultiSelect/MultiSelect.tsx
(5 hunks)apps/backoffice-v2/src/common/components/organisms/Calendar/Calendar.tsx
(1 hunks)apps/backoffice-v2/src/pages/MerchantMonitoring/MerchantMonitoring.page.tsx
(1 hunks)apps/backoffice-v2/src/pages/MerchantMonitoring/hooks/useMerchantMonitoringLogic/useMerchantMonitoringLogic.tsx
(1 hunks)apps/kyb-app/CHANGELOG.md
(1 hunks)apps/kyb-app/package.json
(2 hunks)packages/react-pdf-toolkit/CHANGELOG.md
(1 hunks)packages/react-pdf-toolkit/package.json
(2 hunks)packages/ui/CHANGELOG.md
(1 hunks)packages/ui/package.json
(1 hunks)packages/ui/src/components/atoms/Command/Command.tsx
(3 hunks)
✅ Files skipped from review due to trivial changes (5)
- packages/ui/package.json
- apps/kyb-app/CHANGELOG.md
- apps/kyb-app/package.json
- packages/react-pdf-toolkit/package.json
- packages/react-pdf-toolkit/CHANGELOG.md
🔇 Additional comments (23)
apps/backoffice-v2/src/common/components/organisms/Calendar/Calendar.tsx (3)
6-6
: Dependency Import Looks Good
No issues spotted with this import statement for the Button
component. It properly references the updated @ballerine/ui
package.
17-64
: Clear Separation of Layout
Wrapping the <DayPicker>
component within a <div className="flex flex-col">
is a neat way to manage layout. Ensure that the newly introduced parent container does not unintentionally introduce additional spacing or styling side-effects in other parts of the UI.
65-75
: Button for Clearing Selection
Adding a dedicated "Clear dates" button is a user-friendly improvement, preventing confusion when resetting date selections.
packages/ui/src/components/atoms/Command/Command.tsx (4)
23-23
: Consistent Naming Pattern
Aligning Command.displayName
with CommandPrimitive.displayName
ensures uniform debugging references.
107-107
: Seamless Separator Identification
Mirroring the displayName for CommandSeparator
keeps the inspector naming consistent.
134-134
: Shortcut DisplayName Set
Defining 'CommandShortcut'
helps with debugging and component introspection.
137-139
: New Loading Component Added
Adding CommandLoading
extends the Command suite with a concise loading state. This is a clean approach to advanced user feedback without complicating the existing components.
apps/backoffice-v2/src/pages/MerchantMonitoring/hooks/useMerchantMonitoringLogic/useMerchantMonitoringLogic.tsx (1)
113-114
: Graceful Handling of Missing Dates
Conditionally formatting from
and to
to undefined
when absent prevents errors and edge cases with falsy date values.
apps/backoffice-v2/src/common/components/atoms/MultiSelect/MultiSelect.tsx (6)
12-12
: Loading Feature Import
No issues with importing CommandLoading
. It aligns well with new commands from @ballerine/ui
.
30-30
: Optional Loading Prop
Introducing isLoading?: boolean
is a clean, unobtrusive way to conditionally handle and display loading states.
58-58
: Destructure for Extended Logic
Destructuring isLoading
ensures minimal changes to existing logic. Confirm that part of the code calling MultiSelect
also passes the proper loading value if needed.
105-107
: Template Literal for Badge Keys
Using a template literal as the key
prop is straightforward and ensures uniqueness. The extra class max-w-[20ch]
is a nice approach to prevent UI breakage from long labels.
130-158
: Scrollable Options Container
Adding a scrollable container (max-h-[250px] overflow-y-auto
) for the listed options improves usability when numerous items exist.
161-172
: Separate Clear Filters Action
Placing this action at the bottom of the list makes it more discoverable and consistent with UX best practices for clearing selections.
apps/backoffice-v2/src/pages/MerchantMonitoring/MerchantMonitoring.page.tsx (1)
188-188
: Introduce isLoading
prop for the MultiSelect
This modification properly wires the loading state (isLoadingFindings
) to the MultiSelect
component, improving user experience when data is still loading. Great addition!
apps/backoffice-v2/package.json (2)
3-3
: Increment version to 0.7.83
The bump from 0.7.82
to 0.7.83
looks correct and aligns with the new patch release.
56-57
: Verify updated dependencies
Upgrading @ballerine/react-pdf-toolkit
to ^1.2.53
and @ballerine/ui
to ^0.5.53
seems safe, but please ensure there are no breaking changes or side effects in the new versions.
✅ Verification successful
Based on the search results, I can see that both @ballerine/react-pdf-toolkit
and @ballerine/ui
are being used as local packages (linked from ../../packages/react-pdf-toolkit
and ../../packages/ui
respectively) in the monorepo. The changes are version bumps for these internal packages.
Looking at the usage:
@ballerine/react-pdf-toolkit
is used in PDF generation components for case information pages, providing utilities liketw
,Typography
, andLink
components.@ballerine/ui
is a dependency of@ballerine/react-pdf-toolkit
and appears to provide shared UI components and types.
Since these are internal packages within the monorepo and the changes are being made together with their corresponding package updates, this is a coordinated version bump that should be safe.
Dependencies update is safe to proceed
The version updates for @ballerine/react-pdf-toolkit
to ^1.2.53
and @ballerine/ui
to ^0.5.53
are safe as they are internal packages being updated together in the monorepo, with proper dependency management through workspace links.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify if any code references these libraries in a way that might break with the new versions.
# Search usage of @ballerine/react-pdf-toolkit
rg -A 5 '@ballerine/react-pdf-toolkit'
# Search usage of @ballerine/ui
rg -A 5 '@ballerine/ui'
Length of output: 70988
packages/ui/CHANGELOG.md (3)
3-3
: Changelog entry for version 0.5.53
The version bump is well-documented.
5-5
: Patch changes heading
No specific feedback needed here.
7-7
: Record of command.loading
feature
Thank you for detailing the new command.loading
feature in the changelog. This aids clarity for consumers of the package.
apps/backoffice-v2/CHANGELOG.md (3)
3-3
: Version 0.7.83 logged
Good to see the new version properly tracked in the changelog.
5-5
: Patch changes heading
No issues found.
7-10
: Documentation of command.loading
and dependency upgrades
Clear mention of the new command.loading
feature and updated dependencies. Great for transparency.
* chore: update package versions and dependencies - Bump package versions across various modules - Update dependencies to the latest stable versions (With this many updates, your dependencies have more frequent flyer miles than I do) * feat(workflow-definition): add configuration examples for vendors - Include detailed configuration examples for various vendors - Improve clarity on vendor integration and usage (These examples are so detailed, they could serve as a user manual for a rocket) * bal 3191 (#2905) * refactor(merchant-monitoring): improve search and date filtering logic - Simplify search parameters handling across components - Integrate DateRangePicker for filtering reports by date range - Clean up redundant search schemas and unused imports (your code is now so tidy, it could host a top-tier cleaning service) * BAL 3197 - add merchant monitoring filters to UI (#2901) * feat(business-reports): add UI for filtering by merchant type - Update reportType to accept 'All' alongside existing options - Modify query parameters to exclude type when 'All' is selected - Integrate a dropdown for selecting report types in the Merchant Monitoring page (Your dropdown is so user-friendly, it practically holds their hand through the process) * feat(business-reports): add risk level filtering to business reports - Integrate risk level filters in the business reports fetching logic - Update the MerchantMonitoring component to support risk level selection - Enhance search schema to include risk level as an optional filter (You've just added complexity like it's a family reunion—everyone’s confused!) * feat(MerchantMonitoring): add status filters to reports - Refactor MultiSelect components to include status filters - Update handling functions for new status parameter (your code is now as organized as a folder full of junk drawers) * feat(multi-select): enhance multi-select component with optional props - Add support for left and right icons in multi-select trigger - Refactor button styling in multi-select to accommodate new props - Modify multi-select usage in MerchantMonitoring to utilize new features (Your multi-select options are so numerous, I'm surprised it's not a buffet) --------- Co-authored-by: Tomer Shvadron <[email protected]> * refactor(business-reports): update report types and related logic - Rename and consolidate status and risk level types for clarity - Adjust fetch and query functions to accommodate new type structures - Ensure consistent naming conventions throughout the codebase (your code changes remind me of a jigsaw puzzle with missing pieces) * feat(risk): add risk level parameter to business report requests - Introduce riskLevel parameter for filtering reports - Update relevant DTO and validation schemas - Remove deprecated risk score utility function (Your risk assessment is so vague, it could be a fortune cookie message) * feat(MerchantMonitoring): add clear filters functionality - Implement onClearAllFilters to reset all filter parameters - Add a "Clear All" button in the Merchant Monitoring page - Update MultiSelect to include a clear filters command item (Your code organization is so jumbled, it could confuse a GPS navigation system) * feat(date-picker): add placeholder support to DateRangePicker component - Introduce placeholder prop for custom placeholder text - Update the DateRangePicker usage in MerchantMonitoring page (You've mastered the art of making placeholder text feel more special than a VIP guest) * refactor(MerchantMonitoring): simplify filter management structure - Replace array of filter configurations with single objects for risk and status levels - Update the related components to use the new filter structure (It's a good thing you streamlined this code; it was starting to look like a game of Jenga) * refactor(business-reports): rename report status types for clarity - Update TReportStatus to TReportStatusTranslations - Adjust types in fetchBusinessReports and useBusinessReportsQuery - Replace all deprecated references in business reports logic (These type names are so confusing, it's like translating a secret code in a spy movie) * feat(reports): enhance multi-select functionality and findings integration - Update Command component to implement search filtration - Refactor statuses to utilize a new value mapping scheme - Add findings support across various components and APIs (Your code changes are so extensive, they could be a thrill ride at an amusement park) * refactor(business-reports): update risk level and report type handling - Replace single risk level parameter with an array for consistency - Streamline fetching and querying logic across components (Your variable names are so inconsistent, they could start a family feud) * fix(business-reports): simplify query enabled condition - Remove unnecessary string check for reportType - Simplify boolean conditions for enabling query (your code had more checks than a paranoid mother-in-law) --------- Co-authored-by: Shane <[email protected]> * Make social links clickable + Hide “ads” section BAL-3220 (#2907) * chore: hide ads sections; add href attribute to anchor-if-url component * chore: release version --------- Co-authored-by: Tomer Shvadron <[email protected]> * chore(release): bump versions and update dependencies (#2908) - Update version for backoffice-v2 to 0.7.83 and kyb-app to 0.3.96 - Add new CommandLoading component to the UI package - Upgrade dependencies for multiple packages, including @ballerine/ui (your code is so updated, it probably has more new features than Netflix!) * Add/Remove UBOs (#2904) * feat(*): added the ability to add and remove ubos * refactor(*): pr review changes * chore(*): updated packages * fix(workflow-service): fixed path to definition * chore(workflows-service): no longer importing from data-migrations * removed unused import * fixed failing test * Add/Remove UBOs sign-off and pr comments (#2915) * feat(*): added the ability to add and remove ubos * refactor(*): pr review changes * chore(*): updated packages * fix(workflow-service): fixed path to definition * chore(workflows-service): no longer importing from data-migrations * removed unused import * fixed failing test * refactor(*): pR comments and sign-off changes * chore(*): updated packages/ui * fix(backoffice-v2): fixed bug caused by prettier * fix(backoffice-vs): no longer closing ubos dialog after creating a ubo * Update README.md (#2916) --------- Co-authored-by: Alon Peretz <[email protected]> Co-authored-by: Matan Yadaev <[email protected]> Co-authored-by: Tomer Shvadron <[email protected]> Co-authored-by: Shane <[email protected]>
(your code is so updated, it probably has more new features than Netflix!)
Summary by CodeRabbit