-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added buildFlat to @ballerine/blocks #2376
Conversation
…educe .build().flat(1)
|
WalkthroughThe recent updates encompass a series of enhancements across packages and applications. The key modifications involve dependency upgrades, notably advancing Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
PR Description updated to latest commit (2e679cf) |
PR Review 🔍
Code feedback:
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Out of diff range and nitpick comments (13)
apps/backoffice-v2/CHANGELOG.md (13)
Line range hint
85-85
: Remove duplicated "Updated dependencies" phrase.- - Updated dependencies - - Updated dependencies [9fe7a5c10] + - Updated dependencies [9fe7a5c10]
Line range hint
400-400
: Remove duplicated "Updated dependencies" phrase.- - Updated dependencies - - Updated dependencies [59afd0b4] + - Updated dependencies [59afd0b4]
Line range hint
554-554
: Hyphenate prefixes followed by proper nouns or dates.- - 801fc639: pre - - 801fc639: Pre ver - - 801fc639: Prerelease - - 801fc639: bump pre - - 801fc639: Version bump pre - - 801fc639: Pre bump - - 801fc639: Pre bump - - 801fc639: Bump - - 801fc639: pre - - Version bump - - 801fc639: Pre release - - 801fc639: Bumo + - 801fc639: pre- + - 801fc639: Pre-ver + - 801fc639: Pre-release + - 801fc639: bump pre- + - 801fc639: Version bump pre- + - 801fc639: Pre-bump + - 801fc639: Pre-bump + - 801fc639: Bump + - 801fc639: pre- + - Version bump + - 801fc639: Pre-release + - 801fc639: Bumo
Line range hint
573-573
: Remove duplicated "Updated dependencies" phrase.- - Updated dependencies - - Updated dependencies [801fc639] + - Updated dependencies [801fc639]
Line range hint
624-624
: Hyphenate prefixes followed by proper nouns or dates.- - b1cebf50: bump pre - - b1cebf50: Version bump pre - - Bump - - b1cebf50: Pre bump - - b1cebf50: Pre bump + - b1cebf50: bump pre- + - b1cebf50: Version bump pre- + - Bump + - b1cebf50: Pre-bump + - b1cebf50: Pre-bump
Line range hint
638-638
: Remove duplicated "Updated dependencies" phrase.- - Updated dependencies - - Updated dependencies [b1cebf50] + - Updated dependencies [b1cebf50]
Line range hint
658-658
: Hyphenate prefixes followed by proper nouns or dates.- - Version bump pre + - Version bump pre-
Line range hint
720-720
: Hyphenate prefixes followed by proper nouns or dates.- - bump pre + - bump pre-
Line range hint
756-756
: Hyphenate "Pre release".- - Pre release + - Pre-release
Line range hint
781-781
: Hyphenate prefixes followed by proper nouns or dates.- - pre + - pre-
Line range hint
792-792
: Hyphenate prefixes followed by proper nouns or dates.- - pre + - pre-
Line range hint
985-985
: Remove duplicated "Updated dependencies" phrase.- - Updated dependencies - - Updated dependencies [cce4a663] + - Updated dependencies [cce4a663]
Line range hint
977-977
: Format the heading correctly.- ## 0.4.11 + + ## 0.4.11 +
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!pnpm-lock.yaml
Files selected for processing (11)
- apps/backoffice-v2/CHANGELOG.md (1 hunks)
- apps/backoffice-v2/package.json (2 hunks)
- apps/kyb-app/CHANGELOG.md (1 hunks)
- apps/kyb-app/package.json (2 hunks)
- packages/blocks/.eslintrc.cjs (1 hunks)
- packages/blocks/CHANGELOG.md (1 hunks)
- packages/blocks/package.json (1 hunks)
- packages/blocks/src/blocks.spec-d.ts (2 hunks)
- packages/blocks/src/blocks.spec.ts (2 hunks)
- packages/blocks/src/blocks.ts (5 hunks)
- services/workflows-service/prisma/data-migrations (1 hunks)
Files skipped from review due to trivial changes (6)
- apps/backoffice-v2/package.json
- apps/kyb-app/package.json
- packages/blocks/.eslintrc.cjs
- packages/blocks/package.json
- packages/blocks/src/blocks.ts
- services/workflows-service/prisma/data-migrations
Additional Context Used
LanguageTool (34)
apps/backoffice-v2/CHANGELOG.md (12)
Near line 85: This phrase is duplicated. You should probably use “Updated dependencies” only once.
Context: ...a5c10: bump - 9fe7a5c: Version bump - Updated dependencies - Updated dependencies [9fe7a5c] - Updated dependencies [9fe...
Near line 400: This phrase is duplicated. You should probably use “Updated dependencies” only once.
Context: ...0.5.27 ## 0.5.29 ### Patch Changes - Updated dependencies - Updated dependencies [59afd0b] - @ballerine/[email protected]...
Near line 554: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ...: Pre bump - 801fc63: Bump - 801fc63: pre - Version bump - 801fc63: Pre release - 801fc63...
Near line 573: This phrase is duplicated. You should probably use “Updated dependencies” only once.
Context: ...39] - Updated dependencies [801fc63] - Updated dependencies - Updated dependencies [801fc63] - Updated dependencies [801f...
Near line 624: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ...bf50: bump pre - b1cebf5: Version bump pre - Bump - b1cebf5: Pre bump - b1cebf5: Pre bu...
Near line 638: This phrase is duplicated. You should probably use “Updated dependencies” only once.
Context: ...50] - Updated dependencies [b1cebf5] - Updated dependencies - Updated dependencies [b1cebf5] - Updated dependencies [b1ce...
Near line 658: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ...8.15 ### Patch Changes - Version bump pre - Updated dependencies - @ballerine/workflow-br...
Near line 720: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ...1-3e08f108.9 ### Patch Changes - bump pre - Updated dependencies - @ballerine/workflow-br...
Near line 756: This expression is normally spelled as one or with a hyphen.
Context: ...0.5.11-3e08f108.5 ### Patch Changes - Pre release - Updated dependencies - @ballerine/w...
Near line 781: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ...0.5.11-3e08f108.2 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...
Near line 792: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ...0.5.11-3e08f108.1 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...
Near line 985: This phrase is duplicated. You should probably use “Updated dependencies” only once.
Context: ...> demo ## 0.4.11 ### Patch Changes - Updated dependencies - Updated dependencies [cce4a66] - @ballerine/[email protected] -...apps/kyb-app/CHANGELOG.md (12)
Near line 83: This phrase is duplicated. You should probably use “Updated dependencies” only once.
Context: ...a5c10: bump - 9fe7a5c: Version bump - Updated dependencies - Updated dependencies [9fe7a5c] - Updated dependencies [9fe...
Near line 379: This phrase is duplicated. You should probably use “Updated dependencies” only once.
Context: ...0.5.27 ## 0.1.23 ### Patch Changes - Updated dependencies - Updated dependencies [59afd0b] - @ballerine/[email protected]...
Near line 520: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ...: Pre bump - 801fc63: Bump - 801fc63: pre - Version bump - 801fc63: Pre release - 801fc63...
Near line 539: This phrase is duplicated. You should probably use “Updated dependencies” only once.
Context: ...39] - Updated dependencies [801fc63] - Updated dependencies - Updated dependencies [801fc63] - Updated dependencies [801f...
Near line 586: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ...bf50: bump pre - b1cebf5: Version bump pre - Bump - b1cebf5: Pre bump - b1cebf5: Pre bu...
Near line 600: This phrase is duplicated. You should probably use “Updated dependencies” only once.
Context: ...50] - Updated dependencies [b1cebf5] - Updated dependencies - Updated dependencies [b1cebf5] - Updated dependencies [b1ce...
Near line 619: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ...8.15 ### Patch Changes - Version bump pre - Updated dependencies - @ballerine/workflow-br...
Near line 676: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ...5-3e08f108.9 ### Patch Changes - bump pre - Updated dependencies - @ballerine/workflow-br...
Near line 710: This expression is normally spelled as one or with a hyphen.
Context: ... 0.1.5-3e08f108.5 ### Patch Changes - Pre release - Updated dependencies - @ballerine/w...
Near line 734: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ... 0.1.5-3e08f108.2 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...
Near line 744: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ... 0.1.5-3e08f108.1 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...
Near line 885: This phrase is duplicated. You should probably use “Updated dependencies” only once.
Context: ...ed DynamicForm & TextArea & css fixes - Updated dependencies - Updated dependencies [c06f234] - @ballerine/[email protected] ## ...packages/blocks/CHANGELOG.md (10)
Near line 23: This phrase is duplicated. You should probably use “Updated dependencies” only once.
Context: ...Changes - ver bump - 9fe7a5c: bump - Updated dependencies - Updated dependencies [9fe7a5c] - Updated dependencies [9fe...
Near line 174: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ...: Pre bump - 801fc63: Bump - 801fc63: pre - Version bump - 801fc63: Pre release - 801fc63...
Near line 186: This phrase is duplicated. You should probably use “Updated dependencies” only once.
Context: ...39] - Updated dependencies [801fc63] - Updated dependencies - Updated dependencies [801fc63] - Updated dependencies [801f...
Near line 214: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ...bf50: bump pre - b1cebf5: Version bump pre - Bump - b1cebf5: Pre bump - b1cebf5: Pre bu...
Near line 226: This phrase is duplicated. You should probably use “Updated dependencies” only once.
Context: ...50] - Updated dependencies [b1cebf5] - Updated dependencies - Updated dependencies [b1cebf5] - Updated dependencies [b1ce...
Near line 239: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ...8.10 ### Patch Changes - Version bump pre - Updated dependencies - @ballerine/[email protected]....
Near line 279: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ...1-3e08f108.5 ### Patch Changes - bump pre - Updated dependencies - @ballerine/[email protected]....
Near line 295: This expression is normally spelled as one or with a hyphen.
Context: ...0.1.11-3e08f108.3 ### Patch Changes - Pre release - Updated dependencies - @ballerine/c...
Near line 303: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ...0.1.11-3e08f108.2 ### Patch Changes - pre - Updated dependencies - @ballerine/[email protected]....
Near line 311: Prefixes followed by proper nouns or dates are typically hyphenated.
Context: ...0.1.11-3e08f108.1 ### Patch Changes - pre - Updated dependencies - @ballerine/[email protected]....
Additional comments not posted (3)
packages/blocks/src/blocks.spec-d.ts (1)
318-362
: New test case forbuildFlat
looks good. It correctly verifies the inferred type of the flattened blocks.packages/blocks/src/blocks.spec.ts (1)
344-369
: New test case forbuildFlat
looks good. It correctly verifies the output of the flattened blocks.apps/backoffice-v2/CHANGELOG.md (1)
3-9
: Changelog entry for version0.7.8
looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/blocks/src/blocks.spec-d.ts (2 hunks)
- packages/blocks/src/blocks.ts (5 hunks)
Files skipped from review as they are similar to previous changes (2)
- packages/blocks/src/blocks.spec-d.ts
- packages/blocks/src/blocks.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I am just missing the refactor of .build().flat()
to .buildFlat()
User description
Description
Elaborate on the subject, motivation, and context.
Related issues
Breaking changes
How these changes were tested
Examples and references
Checklist
PR Type
enhancement
Description
buildFlat
method inBlocksBuilder
to simplify flattening of block structures.buildFlat
method.backoffice-v2
andkyb-app
.Changes walkthrough 📝
3 files
blocks.spec-d.ts
Add tests for `buildFlat` and minor type adjustments
packages/blocks/src/blocks.spec-d.ts
buildFlat
method.debug
option increateTestBlocks
to considerprocess.env.CI
.value
inTCell
fromArray
tostring[]
.blocks.spec.ts
Integration tests for `buildFlat` and type adjustments
packages/blocks/src/blocks.spec.ts
buildFlat
method.debug
setting increateTestBlocks
to be environmentsensitive.
value
inTCell
fromArray
tostring[]
.blocks.ts
Implement `buildFlat` method and refactor types
packages/blocks/src/blocks.ts
buildFlat
method inBlocksBuilder
class.Block
andBlocks
types fromArray
to shorthand[]
syntax.syntax.
3 files
CHANGELOG.md
Update changelog for backoffice-v2
apps/backoffice-v2/CHANGELOG.md
CHANGELOG.md
Update changelog for kyb-app
apps/kyb-app/CHANGELOG.md
CHANGELOG.md
Update changelog for blocks package
packages/blocks/CHANGELOG.md
buildFlat
.4 files
package.json
Bump backoffice-v2 version and update blocks dependency
apps/backoffice-v2/package.json
@ballerine/blocks
to version 0.2.3.package.json
Bump kyb-app version and update blocks dependency
apps/kyb-app/package.json
@ballerine/blocks
to version 0.2.3..eslintrc.cjs
Update ESLint configuration in blocks package
packages/blocks/.eslintrc.cjs
parserOptions
withproject
set to./tsconfig.eslint.json
.package.json
Update version in blocks package
packages/blocks/package.json
1 files
pnpm-lock.yaml
Update dependencies in pnpm lock file
pnpm-lock.yaml
Summary by CodeRabbit
New Features
buildFlat
function in the@ballerine/blocks
package for improved performance.Updates
@ballerine/blocks
dependency to version 0.2.3 inbackoffice-v2
andkyb-app
.backoffice-v2
to version 0.7.8 andkyb-app
to version 0.3.9.Bug Fixes