Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added buildFlat to @ballerine/blocks #2376

Merged
merged 3 commits into from
May 15, 2024
Merged

Conversation

Omri-Levy
Copy link
Contributor

@Omri-Levy Omri-Levy commented May 14, 2024

User description

Description

Elaborate on the subject, motivation, and context.

Related issues

  • Provide a link to each related issue.

Breaking changes

  • Describe the breaking changes that this pull request introduces.

How these changes were tested

  • Describe the tests that you ran to verify your changes, including devices, operating systems, browsers and versions.

Examples and references

  • Links, screenshots, and other resources related to this change.

Checklist

  • [] I have read the contribution guidelines of this project
  • [] I have read the style guidelines of this project
  • [] I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings and errors
  • [] New and existing tests pass locally with my changes

PR Type

enhancement


Description

  • Implemented a new buildFlat method in BlocksBuilder to simplify flattening of block structures.
  • Added unit and integration tests for the buildFlat method.
  • Updated type definitions in TypeScript files to use more concise array syntax.
  • Updated package versions and dependencies in backoffice-v2 and kyb-app.
  • Updated changelogs and package versions in response to new features.

Changes walkthrough 📝

Relevant files
Enhancement
3 files
blocks.spec-d.ts
Add tests for `buildFlat` and minor type adjustments         

packages/blocks/src/blocks.spec-d.ts

  • Added a new test suite for buildFlat method.
  • Adjusted the debug option in createTestBlocks to consider
    process.env.CI.
  • Changed type of value in TCell from Array to string[].
  • +48/-2   
    blocks.spec.ts
    Integration tests for `buildFlat` and type adjustments     

    packages/blocks/src/blocks.spec.ts

  • Added integration tests for the buildFlat method.
  • Modified debug setting in createTestBlocks to be environment
    sensitive.
  • Updated type of value in TCell from Array to string[].
  • +28/-2   
    blocks.ts
    Implement `buildFlat` method and refactor types                   

    packages/blocks/src/blocks.ts

  • Introduced buildFlat method in BlocksBuilder class.
  • Changed Block and Blocks types from Array to shorthand [] syntax.
  • Updated several type definitions to use more concise array type
    syntax.
  • +20/-12 
    Documentation
    3 files
    CHANGELOG.md
    Update changelog for backoffice-v2                                             

    apps/backoffice-v2/CHANGELOG.md

  • Added changelog entry for version 0.7.8 noting updated dependencies.
  • +7/-0     
    CHANGELOG.md
    Update changelog for kyb-app                                                         

    apps/kyb-app/CHANGELOG.md

  • Added changelog entry for version 0.3.9 noting updated dependencies.
  • +7/-0     
    CHANGELOG.md
    Update changelog for blocks package                                           

    packages/blocks/CHANGELOG.md

  • Added changelog entry for version 0.2.3 describing the addition of
    buildFlat.
  • +6/-0     
    Configuration changes
    4 files
    package.json
    Bump backoffice-v2 version and update blocks dependency   

    apps/backoffice-v2/package.json

  • Updated version to 0.7.8.
  • Updated dependency for @ballerine/blocks to version 0.2.3.
  • +2/-2     
    package.json
    Bump kyb-app version and update blocks dependency               

    apps/kyb-app/package.json

  • Updated version to 0.3.9.
  • Updated dependency for @ballerine/blocks to version 0.2.3.
  • +2/-2     
    .eslintrc.cjs
    Update ESLint configuration in blocks package                       

    packages/blocks/.eslintrc.cjs

  • Added parserOptions with project set to ./tsconfig.eslint.json.
  • +3/-0     
    package.json
    Update version in blocks package                                                 

    packages/blocks/package.json

    • Updated version to 0.2.3.
    +1/-1     
    Dependencies
    1 files
    pnpm-lock.yaml
    Update dependencies in pnpm lock file                                       

    pnpm-lock.yaml

    • Updated various dependencies to align with new versions.
    +6/-6     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Summary by CodeRabbit

    • New Features

      • Introduced the buildFlat function in the @ballerine/blocks package for improved performance.
    • Updates

      • Updated @ballerine/blocks dependency to version 0.2.3 in backoffice-v2 and kyb-app.
      • Upgraded backoffice-v2 to version 0.7.8 and kyb-app to version 0.3.9.
    • Bug Fixes

      • Enhanced type definitions and testing configurations for better reliability and maintainability.

    Copy link

    changeset-bot bot commented May 14, 2024

    ⚠️ No Changeset found

    Latest commit: e859388

    Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

    This PR includes no changesets

    When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

    Click here to learn what changesets are, and how to add one.

    Click here if you're a maintainer who wants to add a changeset to this PR

    Copy link
    Contributor

    coderabbitai bot commented May 14, 2024

    Walkthrough

    The recent updates encompass a series of enhancements across packages and applications. The key modifications involve dependency upgrades, notably advancing @ballerine/blocks to version 0.2.3. Furthermore, a new feature like the buildFlat function was introduced in the @ballerine/blocks package. Minor type adjustments and additional test cases were also included to fortify the codebase.

    Changes

    File/Path Change Summary
    apps/backoffice-v2/CHANGELOG.md, package.json Updated version to 0.7.8 and upgraded @ballerine/blocks dependency to 0.2.3.
    apps/kyb-app/CHANGELOG.md, package.json Updated version to 0.3.9 and upgraded @ballerine/blocks dependency to 0.2.3.
    packages/blocks/.eslintrc.cjs Added parserOptions with project: './tsconfig.eslint.json'.
    packages/blocks/CHANGELOG.md, package.json Updated version to 0.2.3 and documented the addition of the buildFlat function.
    packages/blocks/src/blocks.spec-d.ts, blocks.spec.ts Adjusted type definitions and added new test cases for the buildFlat function.
    packages/blocks/src/blocks.ts Refined type declarations for better clarity and consistency.

    🐰
    The code has grown, the versions rise,
    Dependencies updated, a pleasant surprise.
    With buildFlat now in the mix,
    Our blocks are ready for new tricks.
    Type tweaks and tests are all in place,
    For a smoother, faster development pace.
    🌟


    Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

    Share
    Tips

    Chat

    There are 3 ways to chat with CodeRabbit:

    • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
      • I pushed a fix in commit <commit_id>.
      • Generate unit testing code for this file.
      • Open a follow-up GitHub issue for this discussion.
    • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
      • @coderabbitai generate unit testing code for this file.
      • @coderabbitai modularize this function.
    • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
      • @coderabbitai generate interesting stats about this repository and render them as a table.
      • @coderabbitai show all the console.log statements in this repository.
      • @coderabbitai read src/utils.ts and generate unit testing code.
      • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

    Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

    CodeRabbit Commands (invoked as PR comments)

    • @coderabbitai pause to pause the reviews on a PR.
    • @coderabbitai resume to resume the paused reviews.
    • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
    • @coderabbitai resolve resolve all the CodeRabbit review comments.
    • @coderabbitai help to get help.

    Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

    CodeRabbit Configration File (.coderabbit.yaml)

    • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
    • Please see the configuration documentation for more information.
    • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

    Documentation and Community

    • Visit our Documentation for detailed information on how to use CodeRabbit.
    • Join our Discord Community to get help, request features, and share feedback.
    • Follow us on X/Twitter for updates and announcements.

    @github-actions github-actions bot added the enhancement New feature or request label May 14, 2024
    Copy link
    Contributor

    PR Description updated to latest commit (2e679cf)

    Copy link
    Contributor

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5]

    4, because the PR involves multiple changes across various files including TypeScript type definitions, method implementations, and package version updates. The complexity and breadth of the changes require careful review to ensure compatibility and functionality.

    🧪 Relevant tests

    Yes

    ⚡ Possible issues

    Possible Bug: The use of process.env.CI in the createTestBlocks function might lead to inconsistent behavior in different environments if not handled properly.

    🔒 Security concerns

    No

    Code feedback:
    relevant filepackages/blocks/src/blocks.ts
    suggestion      

    Consider adding error handling or a fallback mechanism in the buildFlat method to manage cases where the array structure might not be as expected. This can prevent runtime errors and improve the robustness of the method. [important]

    relevant linebuildFlat() {

    relevant filepackages/blocks/src/blocks.spec.ts
    suggestion      

    It would be beneficial to add more comprehensive tests for the buildFlat method to cover edge cases and unusual array structures. This ensures that the method behaves correctly under various conditions. [important]

    relevant linedescribe('when calling `buildFlat`', () => {

    relevant filepackages/blocks/src/blocks.ts
    suggestion      

    Refactor the FlattenOnce type to handle cases where the array includes nested arrays more than one level deep. This enhancement will make the utility type more versatile and applicable in more scenarios. [medium]

    relevant lineexport type FlattenOnce = T extends [infer U, ...infer V]

    relevant filepackages/blocks/src/blocks.spec-d.ts
    suggestion      

    Update the test setup to mock or isolate environment variables such as process.env.CI to ensure that tests are not dependent on the actual environment where they are run. This improves the reliability of the tests. [medium]

    relevant linedebug: !process.env.CI,

    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Enhance control and predictability of debug settings by passing an explicit parameter

    The debug property in createTestBlocks function is toggled based on the CI environment
    variable. This could lead to unexpected behaviors in different environments. If the
    intention is to have explicit control over the debug mode, consider adding an additional
    parameter to the function to set this explicitly.

    packages/blocks/src/blocks.spec-d.ts [16]

    -debug: !process.env.CI,
    +debug: debugMode, // where debugMode is a parameter of createTestBlocks
     
    Suggestion importance[1-10]: 7

    Why: The suggestion is valid and addresses a potential issue with environment-dependent behavior, which could lead to inconsistent debugging states. It proposes a more explicit control mechanism which is a good practice.

    7

    Copy link
    Contributor

    @coderabbitai coderabbitai bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Actionable comments posted: 2

    Out of diff range and nitpick comments (13)
    apps/backoffice-v2/CHANGELOG.md (13)

    Line range hint 85-85: Remove duplicated "Updated dependencies" phrase.

    - - Updated dependencies
    - - Updated dependencies [9fe7a5c10]
    + - Updated dependencies [9fe7a5c10]

    Line range hint 400-400: Remove duplicated "Updated dependencies" phrase.

    - - Updated dependencies
    - - Updated dependencies [59afd0b4]
    + - Updated dependencies [59afd0b4]

    Line range hint 554-554: Hyphenate prefixes followed by proper nouns or dates.

    - - 801fc639: pre
    - - 801fc639: Pre ver
    - - 801fc639: Prerelease
    - - 801fc639: bump pre
    - - 801fc639: Version bump pre
    - - 801fc639: Pre bump
    - - 801fc639: Pre bump
    - - 801fc639: Bump
    - - 801fc639: pre
    - - Version bump
    - - 801fc639: Pre release
    - - 801fc639: Bumo
    + - 801fc639: pre-
    + - 801fc639: Pre-ver
    + - 801fc639: Pre-release
    + - 801fc639: bump pre-
    + - 801fc639: Version bump pre-
    + - 801fc639: Pre-bump
    + - 801fc639: Pre-bump
    + - 801fc639: Bump
    + - 801fc639: pre-
    + - Version bump
    + - 801fc639: Pre-release
    + - 801fc639: Bumo

    Line range hint 573-573: Remove duplicated "Updated dependencies" phrase.

    - - Updated dependencies
    - - Updated dependencies [801fc639]
    + - Updated dependencies [801fc639]

    Line range hint 624-624: Hyphenate prefixes followed by proper nouns or dates.

    - - b1cebf50: bump pre
    - - b1cebf50: Version bump pre
    - - Bump
    - - b1cebf50: Pre bump
    - - b1cebf50: Pre bump
    + - b1cebf50: bump pre-
    + - b1cebf50: Version bump pre-
    + - Bump
    + - b1cebf50: Pre-bump
    + - b1cebf50: Pre-bump

    Line range hint 638-638: Remove duplicated "Updated dependencies" phrase.

    - - Updated dependencies
    - - Updated dependencies [b1cebf50]
    + - Updated dependencies [b1cebf50]

    Line range hint 658-658: Hyphenate prefixes followed by proper nouns or dates.

    - - Version bump pre
    + - Version bump pre-

    Line range hint 720-720: Hyphenate prefixes followed by proper nouns or dates.

    - - bump pre
    + - bump pre-

    Line range hint 756-756: Hyphenate "Pre release".

    - - Pre release
    + - Pre-release

    Line range hint 781-781: Hyphenate prefixes followed by proper nouns or dates.

    - - pre
    + - pre-

    Line range hint 792-792: Hyphenate prefixes followed by proper nouns or dates.

    - - pre
    + - pre-

    Line range hint 985-985: Remove duplicated "Updated dependencies" phrase.

    - - Updated dependencies
    - - Updated dependencies [cce4a663]
    + - Updated dependencies [cce4a663]

    Line range hint 977-977: Format the heading correctly.

    - ## 0.4.11
    + 
    + ## 0.4.11
    + 
    Review Details

    Configuration used: CodeRabbit UI
    Review profile: CHILL

    Commits Files that changed from the base of the PR and between f645eb0 and 2e679cf.
    Files ignored due to path filters (1)
    • pnpm-lock.yaml is excluded by !pnpm-lock.yaml
    Files selected for processing (11)
    • apps/backoffice-v2/CHANGELOG.md (1 hunks)
    • apps/backoffice-v2/package.json (2 hunks)
    • apps/kyb-app/CHANGELOG.md (1 hunks)
    • apps/kyb-app/package.json (2 hunks)
    • packages/blocks/.eslintrc.cjs (1 hunks)
    • packages/blocks/CHANGELOG.md (1 hunks)
    • packages/blocks/package.json (1 hunks)
    • packages/blocks/src/blocks.spec-d.ts (2 hunks)
    • packages/blocks/src/blocks.spec.ts (2 hunks)
    • packages/blocks/src/blocks.ts (5 hunks)
    • services/workflows-service/prisma/data-migrations (1 hunks)
    Files skipped from review due to trivial changes (6)
    • apps/backoffice-v2/package.json
    • apps/kyb-app/package.json
    • packages/blocks/.eslintrc.cjs
    • packages/blocks/package.json
    • packages/blocks/src/blocks.ts
    • services/workflows-service/prisma/data-migrations
    Additional Context Used
    LanguageTool (34)
    apps/backoffice-v2/CHANGELOG.md (12)

    Near line 85: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...a5c10: bump - 9fe7a5c: Version bump - Updated dependencies - Updated dependencies [9fe7a5c] - Updated dependencies [9fe...


    Near line 400: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...0.5.27 ## 0.5.29 ### Patch Changes - Updated dependencies - Updated dependencies [59afd0b] - @ballerine/[email protected]...


    Near line 554: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...: Pre bump - 801fc63: Bump - 801fc63: pre - Version bump - 801fc63: Pre release - 801fc63...


    Near line 573: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...39] - Updated dependencies [801fc63] - Updated dependencies - Updated dependencies [801fc63] - Updated dependencies [801f...


    Near line 624: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...bf50: bump pre - b1cebf5: Version bump pre - Bump - b1cebf5: Pre bump - b1cebf5: Pre bu...


    Near line 638: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...50] - Updated dependencies [b1cebf5] - Updated dependencies - Updated dependencies [b1cebf5] - Updated dependencies [b1ce...


    Near line 658: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...8.15 ### Patch Changes - Version bump pre - Updated dependencies - @ballerine/workflow-br...


    Near line 720: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...1-3e08f108.9 ### Patch Changes - bump pre - Updated dependencies - @ballerine/workflow-br...


    Near line 756: This expression is normally spelled as one or with a hyphen.
    Context: ...0.5.11-3e08f108.5 ### Patch Changes - Pre release - Updated dependencies - @ballerine/w...


    Near line 781: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.5.11-3e08f108.2 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...


    Near line 792: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.5.11-3e08f108.1 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...


    Near line 985: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...> demo ## 0.4.11 ### Patch Changes - Updated dependencies - Updated dependencies [cce4a66] - @ballerine/[email protected] -...

    apps/kyb-app/CHANGELOG.md (12)

    Near line 83: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...a5c10: bump - 9fe7a5c: Version bump - Updated dependencies - Updated dependencies [9fe7a5c] - Updated dependencies [9fe...


    Near line 379: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...0.5.27 ## 0.1.23 ### Patch Changes - Updated dependencies - Updated dependencies [59afd0b] - @ballerine/[email protected]...


    Near line 520: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...: Pre bump - 801fc63: Bump - 801fc63: pre - Version bump - 801fc63: Pre release - 801fc63...


    Near line 539: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...39] - Updated dependencies [801fc63] - Updated dependencies - Updated dependencies [801fc63] - Updated dependencies [801f...


    Near line 586: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...bf50: bump pre - b1cebf5: Version bump pre - Bump - b1cebf5: Pre bump - b1cebf5: Pre bu...


    Near line 600: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...50] - Updated dependencies [b1cebf5] - Updated dependencies - Updated dependencies [b1cebf5] - Updated dependencies [b1ce...


    Near line 619: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...8.15 ### Patch Changes - Version bump pre - Updated dependencies - @ballerine/workflow-br...


    Near line 676: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...5-3e08f108.9 ### Patch Changes - bump pre - Updated dependencies - @ballerine/workflow-br...


    Near line 710: This expression is normally spelled as one or with a hyphen.
    Context: ... 0.1.5-3e08f108.5 ### Patch Changes - Pre release - Updated dependencies - @ballerine/w...


    Near line 734: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ... 0.1.5-3e08f108.2 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...


    Near line 744: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ... 0.1.5-3e08f108.1 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...


    Near line 885: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...ed DynamicForm & TextArea & css fixes - Updated dependencies - Updated dependencies [c06f234] - @ballerine/[email protected] ## ...

    packages/blocks/CHANGELOG.md (10)

    Near line 23: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...Changes - ver bump - 9fe7a5c: bump - Updated dependencies - Updated dependencies [9fe7a5c] - Updated dependencies [9fe...


    Near line 174: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...: Pre bump - 801fc63: Bump - 801fc63: pre - Version bump - 801fc63: Pre release - 801fc63...


    Near line 186: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...39] - Updated dependencies [801fc63] - Updated dependencies - Updated dependencies [801fc63] - Updated dependencies [801f...


    Near line 214: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...bf50: bump pre - b1cebf5: Version bump pre - Bump - b1cebf5: Pre bump - b1cebf5: Pre bu...


    Near line 226: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...50] - Updated dependencies [b1cebf5] - Updated dependencies - Updated dependencies [b1cebf5] - Updated dependencies [b1ce...


    Near line 239: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...8.10 ### Patch Changes - Version bump pre - Updated dependencies - @ballerine/[email protected]....


    Near line 279: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...1-3e08f108.5 ### Patch Changes - bump pre - Updated dependencies - @ballerine/[email protected]....


    Near line 295: This expression is normally spelled as one or with a hyphen.
    Context: ...0.1.11-3e08f108.3 ### Patch Changes - Pre release - Updated dependencies - @ballerine/c...


    Near line 303: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.1.11-3e08f108.2 ### Patch Changes - pre - Updated dependencies - @ballerine/[email protected]....


    Near line 311: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.1.11-3e08f108.1 ### Patch Changes - pre - Updated dependencies - @ballerine/[email protected]....

    Additional comments not posted (3)
    packages/blocks/src/blocks.spec-d.ts (1)

    318-362: New test case for buildFlat looks good. It correctly verifies the inferred type of the flattened blocks.

    packages/blocks/src/blocks.spec.ts (1)

    344-369: New test case for buildFlat looks good. It correctly verifies the output of the flattened blocks.

    apps/backoffice-v2/CHANGELOG.md (1)

    3-9: Changelog entry for version 0.7.8 looks good.

    apps/kyb-app/CHANGELOG.md Show resolved Hide resolved
    packages/blocks/CHANGELOG.md Show resolved Hide resolved
    Copy link
    Contributor

    @coderabbitai coderabbitai bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Actionable comments posted: 0

    Review Details

    Configuration used: CodeRabbit UI
    Review profile: CHILL

    Commits Files that changed from the base of the PR and between 2e679cf and d0fd40e.
    Files selected for processing (2)
    • packages/blocks/src/blocks.spec-d.ts (2 hunks)
    • packages/blocks/src/blocks.ts (5 hunks)
    Files skipped from review as they are similar to previous changes (2)
    • packages/blocks/src/blocks.spec-d.ts
    • packages/blocks/src/blocks.ts

    Copy link
    Collaborator

    @tomer-shvadron tomer-shvadron left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Awesome, I am just missing the refactor of .build().flat() to .buildFlat()

    packages/blocks/src/blocks.spec-d.ts Show resolved Hide resolved
    @Omri-Levy Omri-Levy enabled auto-merge (squash) May 15, 2024 08:24
    @Omri-Levy Omri-Levy merged commit 286a96d into dev May 15, 2024
    9 checks passed
    @Omri-Levy Omri-Levy deleted the omri-levy/feat/blocks-flatten branch May 15, 2024 08:30
    @Omri-Levy Omri-Levy mentioned this pull request Nov 4, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants