WIP - NX NPM scripts #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…with nx run app:script format
…ncy across npm scripts
Omri-Levy
commented
Oct 27, 2022
There was a problem hiding this comment.
Please note the following;
- The use of nx affected might be something undesired for format/lint, subject to change where to use affected
- The --projects flag for commands like dev is something that could include other projects that make sense to be ran in parallel, currently it only includes web-sdk
- Changed web-sdk's preview command to start to ensure parity, non-vite projects such as node projects expect a start script, this allows running start from root with no error or excluding Vite projects
- Formatting changes are due to testing the lint and format commands, should be a non-issue when the formatting/ci PRs are merged
- Right now the test scripts only echo a message, this will be as part of the tests PRs
alonp99
approved these changes
Oct 27, 2022
MihirMandviwala
pushed a commit
that referenced
this pull request
Feb 12, 2024
* (chore): init commit for opening a wip pr * (refactor): replaced pnpm exec in npm scripts to adhere to nx's docs with nx run app:script format * (refactor): removed start: prefix from npm scripts to ensure consistency across npm scripts * (build): added npm scripts expected from a monorepo to the root's package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing scripts one would expect from a monorepo, refactors script names and commands to be more consistent and adhere to NX's docs.