Generate code using OpenAPI Specification, update Readme.md, Added 2 test cases. #2

Pranavan-S · 2025-01-02T12:11:30Z

Purpose

Examples

Checklist

…-templates-80 Add Generated Connector Template (Standard)

…es.toml

…bSpot CRM

CLAassistant · 2025-01-02T12:11:37Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ Pranavan-S
✅ MohamedSabthar
❌ maheshika
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Pranavan-S · 2025-01-02T12:15:12Z

Currently, I have added two test cases and am working on the others too.

…sistency

MohamedSabthar · 2025-01-03T09:24:59Z

docs/spec/sanitations.md

+
+    * Original: `https://api.hubapi.com`
+    * Updated: `https://api.hubapi.com/crm/v3/objects/discounts`
+    * Reason: This change is made to ensure that    all API paths are relative to the versioned base URL (crm/v3/objects/taxes), which improves the consistency and usability of the APIs.


Suggested change

* Reason: This change is made to ensure that all API paths are relative to the versioned base URL (crm/v3/objects/taxes), which improves the consistency and usability of the APIs.

* Reason: This change is made to ensure that all API paths are relative to the versioned base URL (crm/v3/objects/taxes), which improves the consistency and usability of the APIs.

Changed

Pranavan-S@22b1a46

…te test function

…Spot discounts

…ting discounts

… file notice in types.bal

…n in tests.bal

MohamedSabthar · 2025-01-08T05:12:54Z

README.md

+   properties: ["hs_label", "hs_value", "hs_type"]
+};
+
+CollectionResponseSimplePublicObjectWithAssociationsForwardPaging|error response = check hubspotClient->/.get({}, params);


Suggested change

CollectionResponseSimplePublicObjectWithAssociationsForwardPaging|error response = check hubspotClient->/.get({}, params);

CollectionResponseSimplePublicObjectWithAssociationsForwardPaging response = check hubspotClient->/.get({}, params);

Avoid using error union type when using check expression
You can read more about check expression here: https://ballerina.io/learn/by-example/check-expression/

Check and update other places.

MohamedSabthar · 2025-01-08T05:26:53Z

ballerina/tests/tests.bal

+    CollectionResponseSimplePublicObjectWithAssociationsForwardPaging|error response = check hubspotClient->/.get({}, params);
+    if response is CollectionResponseSimplePublicObjectWithAssociationsForwardPaging {
+        test:assertNotEquals(response.results, [], "No discounts found");
+        test:assertTrue(response.results.length() <= 10, "Limit Exceeded");
+        test:assertNotEquals(response.results[0].id, (), "Discount id is not found");
+        test:assertNotEquals(response.results[0].properties, (), "Discount properties are not found");
+        test:assertNotEquals(response.results[0].properties["hs_type"], (), "Discount label is not found");
+        test:assertNotEquals(response.results[0].properties["hs_value"], (), "Discount value is not found");
+        test:assertNotEquals(response.results[0].properties["hs_label"], (), "Discount type is not found");
+    } else {
+        test:assertFail("Error occurred while fetching discounts");
+    }


Suggested change

CollectionResponseSimplePublicObjectWithAssociationsForwardPaging|error response = check hubspotClient->/.get({}, params);

if response is CollectionResponseSimplePublicObjectWithAssociationsForwardPaging {

test:assertNotEquals(response.results, [], "No discounts found");

test:assertTrue(response.results.length() <= 10, "Limit Exceeded");

test:assertNotEquals(response.results[0].id, (), "Discount id is not found");

test:assertNotEquals(response.results[0].properties, (), "Discount properties are not found");

test:assertNotEquals(response.results[0].properties["hs_type"], (), "Discount label is not found");

test:assertNotEquals(response.results[0].properties["hs_value"], (), "Discount value is not found");

test:assertNotEquals(response.results[0].properties["hs_label"], (), "Discount type is not found");

} else {

test:assertFail("Error occurred while fetching discounts");

}

CollectionResponseSimplePublicObjectWithAssociationsForwardPaging response = check hubspotClient->/.get({}, params);

test:assertNotEquals(response.results, [], "No discounts found");

test:assertTrue(response.results.length() <= 10, "Limit Exceeded");

test:assertNotEquals(response.results[0].id, (), "Discount id is not found");

test:assertNotEquals(response.results[0].properties, (), "Discount properties are not found");

test:assertNotEquals(response.results[0].properties["hs_type"], (), "Discount label is not found");

test:assertNotEquals(response.results[0].properties["hs_value"], (), "Discount value is not found");

test:assertNotEquals(response.results[0].properties["hs_label"], (), "Discount type is not found");

check and update other places.

Other places are checked and resolved.

MohamedSabthar · 2025-01-08T05:28:00Z

ballerina/tests/tests.bal

+        test:assertNotEquals(response.results, [], "No discounts found");
+        test:assertTrue(response.results.length() <= 10, "Limit Exceeded");
+        test:assertNotEquals(response.results[0].id, (), "Discount id is not found");
+        test:assertNotEquals(response.results[0].properties, (), "Discount properties are not found");
+        test:assertNotEquals(response.results[0].properties["hs_type"], (), "Discount label is not found");
+        test:assertNotEquals(response.results[0].properties["hs_value"], (), "Discount value is not found");
+        test:assertNotEquals(response.results[0].properties["hs_label"], (), "Discount type is not found");


Instead of individually checking and validating these values, can't we compare the entire response with an expected response? if that's possible let's do that. And update the other test cases tool

MohamedSabthar · 2025-01-08T05:30:26Z

docs/spec/sanitations.md

+_Created_: 17th Dec 2024 \
+_Updated_: 19th Dec 2024 \


Suggested change

_Created_: 17th Dec 2024 \

_Updated_: 19th Dec 2024 \

_Created_: 2024/12/17 \

_Updated_: 2024/12/17 \

…consistency

Pranavan-S · 2025-01-08T08:44:53Z

This PR was closed due to irrelevant commit history.

Refer this PR:
#3

maheshika and others added 18 commits December 16, 2024 10:15

Initial commit

4cbe9ad

Add Issue Template

50babb2

Add Pull Request Template

e2ca943

Apply library repo template

7b24b90

Merge pull request ballerina-platform#1 from ballerina-platform/apply…

d1c77d9

…-templates-80 Add Generated Connector Template (Standard)

update overview

9db1aa1

changed from java21 to java17

d4e7b9b

changed 'date-time' to 'datetime'

734734a

Create test.bal

5304ba6

generated using OpenAPI tool

2fa4ad1

Update

38abb3c

Update resource screen shots

09d8da3

Update setup guide

10a993c

Update document

7c479b6

create testRead and testList

c883eb1

Update README for clarity and bump distribution version in Dependenci…

d8f7949

…es.toml

Refine README to enhance clarity and update module description for Hu…

2a11bdd

…bSpot CRM

[Automated] Update the toml files

3140a3d

Pranavan-S added 4 commits January 3, 2025 09:58

Add update and delete test functions for HubSpot discounts

fe229c6

Refactor HubSpot discounts API endpoints for improved clarity and con…

c5b8edb

…sistency

Add documentation for API key configurations in types.bal

a6836c0

Update test assertion for discount response length to enforce limit

f6d7179

MohamedSabthar reviewed Jan 3, 2025

View reviewed changes

Pranavan-S added 5 commits January 5, 2025 18:39

Add batch update and read tests for HubSpot discounts; implement crea…

833fbf3

…te test function

Update distribution version in Dependencies.toml to 2201.10.3

3a00437

Add batch create and archive tests for HubSpot discounts

a9cafca

Add search test for HubSpot discounts with validation checks

a40b3c8

Remove unused imports and logging in the create test function for Hub…

63b1a19

…Spot discounts

Pranavan-S added 14 commits January 7, 2025 13:47

Remove auto-generated file notice from tests.bal

cef1a4f

Add copyright notice to auto-generated files

dd46653

Update distribution version in Dependencies.toml to 2201.10.3

37e5d8c

Refactor README.md to improve code formatting and add example for lis…

13f83aa

…ting discounts

Remove unnecessary blank line in client.bal and update auto-generated…

ad98e3c

… file notice in types.bal

Add documentation comments for ApiKeysConfig fields in types.bal

f3d9988

Add missing newline in client.bal for improved readability

8d4e967

Add documentation comments for ApiKeysConfig fields in types.bal

3f355c3

[Automated] Update the toml files

24813fe

Add missing newline in client.bal for improved readability

e4f82e5

Remove unused configurable variable and simplify client initializatio…

4345475

…n in tests.bal

Refactor ConnectionConfig structure in README.md for improved clarity

eaf95e3

MohamedSabthar reviewed Jan 8, 2025

View reviewed changes

Pranavan-S added 9 commits January 8, 2025 11:15

Update date format in sanitations.md for consistency

3388b79

No code changes made; skipping commit.

16d5e90

Add HubSpot discounts management functionality in main.bal

e41b0db

Add initial configuration files for festival discounts package

8b6b9c2

Update distribution version in Dependencies.toml to 2201.10.3

f0271f9

[Automated] Update the toml files

32ee676

Add new dependencies and update version for festival discounts package

daac228

Refactor discount creation and update logic for improved clarity and …

5fac941

…consistency

Update distribution version to 2201.10.3 and add 'io' module dependency

dc8609c

Pranavan-S closed this Jan 8, 2025

Pranavan-S force-pushed the main branch from 00dd3ea to dc8609c Compare January 8, 2025 07:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate code using OpenAPI Specification, update Readme.md, Added 2 test cases. #2

Generate code using OpenAPI Specification, update Readme.md, Added 2 test cases. #2

Pranavan-S commented Jan 2, 2025 •

edited

Loading

CLAassistant commented Jan 2, 2025 •

edited

Loading

Pranavan-S commented Jan 2, 2025

MohamedSabthar Jan 3, 2025

Pranavan-S Jan 7, 2025 •

edited

Loading

MohamedSabthar Jan 8, 2025

MohamedSabthar Jan 8, 2025

Pranavan-S Jan 8, 2025

MohamedSabthar Jan 8, 2025

Pranavan-S Jan 8, 2025

MohamedSabthar Jan 8, 2025

MohamedSabthar Jan 8, 2025

Pranavan-S Jan 8, 2025

Pranavan-S commented Jan 8, 2025

	* Reason: This change is made to ensure that all API paths are relative to the versioned base URL (crm/v3/objects/taxes), which improves the consistency and usability of the APIs.
	* Reason: This change is made to ensure that all API paths are relative to the versioned base URL (crm/v3/objects/taxes), which improves the consistency and usability of the APIs.

	CollectionResponseSimplePublicObjectWithAssociationsForwardPaging\|error response = check hubspotClient->/.get({}, params);
	CollectionResponseSimplePublicObjectWithAssociationsForwardPaging response = check hubspotClient->/.get({}, params);

Generate code using OpenAPI Specification, update Readme.md, Added 2 test cases. #2

Generate code using OpenAPI Specification, update Readme.md, Added 2 test cases. #2

Conversation

Pranavan-S commented Jan 2, 2025 • edited Loading

Purpose

Examples

Checklist

CLAassistant commented Jan 2, 2025 • edited Loading

Pranavan-S commented Jan 2, 2025

Choose a reason for hiding this comment

Pranavan-S Jan 7, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pranavan-S commented Jan 8, 2025

Pranavan-S commented Jan 2, 2025 •

edited

Loading

CLAassistant commented Jan 2, 2025 •

edited

Loading

Pranavan-S Jan 7, 2025 •

edited

Loading