Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate Changes to Support Ballerina 2201.8.x Versions #533

Merged
merged 13 commits into from
Mar 5, 2024

Conversation

dsplayerX
Copy link
Contributor

@dsplayerX dsplayerX commented Mar 5, 2024

Purpose

Fixes #534

This PR addresses the need to isolate changes for the upcoming 1.8.x releases of the transaction module, ensuring compatibility with Ballerina version 2201.8.x. (Excludes any changes that are only compatible with versions above 2201.9.0.)

Goals

  • Maintain compatibility with Ballerina version 2201.8.x within the transaction module.
  • Prepare the transaction module for upcoming 1.8.x releases by including all relevant changes since v1.8.0.

Approach

  • A new branch named "1.8.x" was created to isolate changes specific to the 1.8.x releases with Ballerina version 2201.8.x.
  • This branch includes all commits from v1.8.0 up to the latest fix that support Ballerina 2201.8.x (Swan Lake 8) version.
  • Dependencies have been updated to ensure compatibility with the latest Ballerina version 2201.8.5.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

dsplayerX added 11 commits March 5, 2024 10:54
(cherry picked from commit 810403f)
(cherry picked from commit ee909bf)
This change is necessary for compatibility with pull request ballerina-platform#529, which requires changes released with version 2201.8.5.
This new branch 1.8.x will be used for future patches that require lang version 2201.8.x.
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 54.71698% with 24 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (1.8.x@2f780ad). Click here to learn what that means.

Files Patch % Lines
transaction-ballerina/commons.bal 54.34% 21 Missing ⚠️
transaction-ballerina/transaction_block.bal 57.14% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             1.8.x     #533   +/-   ##
========================================
  Coverage         ?   54.46%           
  Complexity       ?       16           
========================================
  Files            ?       22           
  Lines            ?      683           
  Branches         ?      322           
========================================
  Hits             ?      372           
  Misses           ?      310           
  Partials         ?        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gradle.properties Outdated Show resolved Hide resolved
@dsplayerX dsplayerX force-pushed the transaction_1.8.x branch from 6533536 to b002fa1 Compare March 5, 2024 09:51
@dsplayerX dsplayerX force-pushed the transaction_1.8.x branch from 953ca43 to de5c1b6 Compare March 5, 2024 10:21
@dsplayerX dsplayerX force-pushed the transaction_1.8.x branch from de5c1b6 to c1f6918 Compare March 5, 2024 10:38
Copy link
Member

@pcnfernando pcnfernando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcnfernando pcnfernando merged commit 2e16bfe into ballerina-platform:1.8.x Mar 5, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants