Fix strand hanging when strand count exceeds BALLERINA_SQL_MAX_POOL_SIZE #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MohamedSabthar
changed the title
MohamedSabthar
requested review from
niveathika,
RDPerera and
shafreenAnfar
as code owners
daneshk
approved these changes
Oct 9, 2024
|
@MohamedSabthar I feel it would be better if we could add a description to the PR providing the proper reason for this issue and how this suggestion would fix this issue. WDYT ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: ballerina-platform/ballerina-library#7244
The SynchronousQueue does not buffer tasks and only acts as a hand-off point. This causes the ThreadPoolExecutor to fail with a RejectedExecutionException, leading to unexecuted tasks and causing the Ballerina future to remain incomplete. As a result, the Ballerina strand hangs indefinitely.
Changing the SynchronousQueue to a LinkedBlockingQueue allows for task buffering, which eliminates the RejectedExecutionException and improves task execution.
Examples
Checklist