Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make listener configuration as an included parameter #1421

Merged
merged 6 commits into from
Jan 28, 2025

Conversation

TharmiganK
Copy link
Contributor

@TharmiganK TharmiganK commented Jan 28, 2025

Purpose

$Subject

Part of: ballerina-platform/ballerina-library#7494

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.29%. Comparing base (b007b50) to head (116b3de).
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1421      +/-   ##
============================================
- Coverage     84.47%   83.29%   -1.18%     
- Complexity      244      341      +97     
============================================
  Files            28       37       +9     
  Lines          1288     1634     +346     
  Branches        157      239      +82     
============================================
+ Hits           1088     1361     +273     
- Misses          140      172      +32     
- Partials         60      101      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohamedSabthar
Copy link
Member

@TharmiganK don't we have to bump the minor version ?

@TharmiganK
Copy link
Contributor Author

@TharmiganK don't we have to bump the minor version ?

Thinking of adding this with Update 11 and the minor version is already bumped for Update 11

@TharmiganK TharmiganK merged commit 5d68b71 into master Jan 28, 2025
8 checks passed
@TharmiganK TharmiganK deleted the listener-config branch January 28, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants