Implement datamapper #532
Merged
Implement datamapper #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llerina-dev-tools into data-mapped-model
…llerina-dev-tools into data-mapped-model
…llerina-dev-tools into data-mapped-model
…a-dev-tools into data-mapped-model
…a-dev-tools into data-mapped-model
KavinduZoysa
force-pushed
the
data-mapped-model
branch
2 times, most recently
from
82ff345 to
004da77
Compare
KavinduZoysa
requested review from
hasithaa,
dulajdilshan,
LakshanWeerasinghe and
nipunayf
nipunayf
reviewed
Jan 8, 2025
...main/java/io/ballerina/flowmodelgenerator/extension/request/DataMapperAddElementRequest.java
Outdated
Show resolved
Hide resolved
KavinduZoysa
force-pushed
the
data-mapped-model
branch
from
004da77 to
ef1d73c
Compare
LakshanWeerasinghe
approved these changes
Jan 9, 2025
nipunayf
reviewed
Jan 9, 2025
|
|
||
| resource function post getPerson(@http:Payload User user) returns Person|http:InternalServerError { | ||
| do { | ||
| // User1 user1 = {user2: {user3: {i3: user.name.length(), user4: {user5: {u: [user.name, user.name]}}}}, s1: user.name}; |
There was a problem hiding this comment.
Why is this line commented? I've noticed this in other test cases too.
Comment on lines
+40
to
+51
| @DataProvider(name = "data-provider") | ||
| @Override | ||
| protected Object[] getConfigsList() { | ||
| return new Object[][]{ | ||
| {Path.of("variable1.json")}, | ||
| {Path.of("variable2.json")}, | ||
| {Path.of("variable3.json")}, | ||
| {Path.of("variable4.json")}, | ||
| {Path.of("variable5.json")}, | ||
| {Path.of("variable6.json")}, | ||
| {Path.of("variable7.json")}, | ||
| }; |
There was a problem hiding this comment.
By default, the method captures all the JSON files in the selected directory. No need to specify each JSON file.
| DataMapManager dataMapManager = new DataMapManager(workspaceManager, semanticModel.get(), | ||
| document.get()); | ||
| response.setSource(dataMapManager.addElement(request.flowNode(), request.propertyKey(), | ||
| Path.of(request.filePath()), request.targetField(), project, request.position())); |
There was a problem hiding this comment.
There are few occurrences of this
Suggested change
| Path.of(request.filePath()), request.targetField(), project, request.position())); | |
| filePath, request.targetField(), project, request.position())); |
| return null; | ||
| } | ||
|
|
||
| Type type = Type.fromSemanticSymbol(targetNode.typeSymbol()); |
There was a problem hiding this comment.
We are planning to deprecate this model. Is there a reason why we're sticking to this model instead of using the new types model?
| return null; | ||
| } | ||
|
|
||
| private record TargetNode(TypeSymbol typeSymbol, String name, ExpressionNode expressionNode) { |
There was a problem hiding this comment.
Can we define this at the top?
Comment on lines
+623
to
+632
| for (Map.Entry<String, Object> stringObjectEntry : mappings.entrySet()) { | ||
| sb.append(stringObjectEntry.getKey()).append(":"); | ||
| sb.append(genSource(stringObjectEntry.getValue())); | ||
|
|
||
| if (i != len - 1) { | ||
| sb.append(","); | ||
| } | ||
| i = i + 1; | ||
| } | ||
| sb.append("}"); |
There was a problem hiding this comment.
Suggested change
| for (Map.Entry<String, Object> stringObjectEntry : mappings.entrySet()) { | |
| sb.append(stringObjectEntry.getKey()).append(":"); | |
| sb.append(genSource(stringObjectEntry.getValue())); | |
| if (i != len - 1) { | |
| sb.append(","); | |
| } | |
| i = i + 1; | |
| } | |
| sb.append("}"); | |
| StringJoiner joiner = new StringJoiner(","); | |
| mappings.forEach((key, value) -> joiner.add(key + ":" + genSource(value))); | |
| sb.append(joiner); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject