-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implicitly add the import when opening the form of a node template #521
Conversation
528215b
to
1afcbab
Compare
1afcbab
to
0321015
Compare
how are we going to handle if user close the node template without saving anything? |
When the user opens the form, the LS starts a shadowed project and applies all changes to that shadow project. If the user closes without saving, the shadowed project is closed, and the state reverts to what it was before opening the expression editor. |
Proposal
Currently, when opening a node form from the node palette, the imports required for the types used in the node are not automatically added to the source code. This results in unnecessary diagnostics about missing imports being displayed to users. This PR addresses this issue by automatically adding the required imports when opening a node form.
Approach
The implementation approach consists of four main components:
_
is allowed in org/package/module namesSecurity checks