-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jsreds/add device is pined on release 2c #1672
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSReds
force-pushed
the
jsreds/add-device-is-pined-on-release-2c
branch
2 times, most recently
from
June 19, 2024 11:15
7c68b5b
to
1763f38
Compare
JSReds
force-pushed
the
jsreds/add-device-is-pined-on-release-2c
branch
8 times, most recently
from
June 25, 2024 17:07
cf76c34
to
4c33425
Compare
thgreasi
reviewed
Jun 25, 2024
JSReds
force-pushed
the
jsreds/add-device-is-pined-on-release-2c
branch
from
June 26, 2024 11:49
4c33425
to
aae2f3f
Compare
thgreasi
force-pushed
the
jsreds/add-device-is-pined-on-release-2c
branch
2 times, most recently
from
June 27, 2024 14:19
9d58731
to
33d2d84
Compare
JSReds
force-pushed
the
jsreds/add-device-is-pined-on-release-2c
branch
from
June 28, 2024 09:53
33d2d84
to
ca6c414
Compare
thgreasi
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's wait for an extra approval on both oB & bC
JSReds
force-pushed
the
jsreds/add-device-is-pined-on-release-2c
branch
2 times, most recently
from
July 2, 2024 13:55
85fed66
to
8f741b7
Compare
JSReds
force-pushed
the
jsreds/add-device-is-pined-on-release-2c
branch
from
July 2, 2024 14:08
8f741b7
to
310e1a4
Compare
otaviojacobi
approved these changes
Jul 2, 2024
JSReds
force-pushed
the
jsreds/add-device-is-pined-on-release-2c
branch
3 times, most recently
from
July 9, 2024 11:54
16a6c09
to
7fc81f4
Compare
Change-type: minor
JSReds
force-pushed
the
jsreds/add-device-is-pined-on-release-2c
branch
from
July 9, 2024 15:11
7fc81f4
to
84da36e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1095
Project: https://balena.fibery.io/Work/Project/Server-side-pagination-for-devices-Cycle-3-539