Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsreds/add device is pined on release 2c #1672

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

JSReds
Copy link
Contributor

@JSReds JSReds commented Jun 19, 2024

@JSReds JSReds self-assigned this Jun 19, 2024
@JSReds JSReds force-pushed the jsreds/add-device-is-pined-on-release-2c branch 2 times, most recently from 7c68b5b to 1763f38 Compare June 19, 2024 11:15
@JSReds JSReds requested a review from thgreasi June 19, 2024 11:15
@JSReds JSReds force-pushed the jsreds/add-device-is-pined-on-release-2c branch 8 times, most recently from cf76c34 to 4c33425 Compare June 25, 2024 17:07
@JSReds JSReds force-pushed the jsreds/add-device-is-pined-on-release-2c branch from 4c33425 to aae2f3f Compare June 26, 2024 11:49
@thgreasi thgreasi force-pushed the jsreds/add-device-is-pined-on-release-2c branch 2 times, most recently from 9d58731 to 33d2d84 Compare June 27, 2024 14:19
@JSReds JSReds force-pushed the jsreds/add-device-is-pined-on-release-2c branch from 33d2d84 to ca6c414 Compare June 28, 2024 09:53
Copy link
Member

@thgreasi thgreasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's wait for an extra approval on both oB & bC

@JSReds JSReds force-pushed the jsreds/add-device-is-pined-on-release-2c branch 2 times, most recently from 85fed66 to 8f741b7 Compare July 2, 2024 13:55
@JSReds JSReds force-pushed the jsreds/add-device-is-pined-on-release-2c branch from 8f741b7 to 310e1a4 Compare July 2, 2024 14:08
@JSReds JSReds force-pushed the jsreds/add-device-is-pined-on-release-2c branch 3 times, most recently from 16a6c09 to 7fc81f4 Compare July 9, 2024 11:54
@JSReds JSReds force-pushed the jsreds/add-device-is-pined-on-release-2c branch from 7fc81f4 to 84da36e Compare July 9, 2024 15:11
@JSReds JSReds marked this pull request as ready for review July 9, 2024 15:11
@thgreasi thgreasi enabled auto-merge July 9, 2024 15:18
@thgreasi thgreasi merged commit 1c6d857 into master Jul 9, 2024
50 checks passed
@thgreasi thgreasi deleted the jsreds/add-device-is-pined-on-release-2c branch July 9, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should change device's should_be_running__release to is_pinned_on__release
3 participants