-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V18 Major #1370
Merged
Merged
V18 Major #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otaviojacobi
force-pushed
the
v-18-major
branch
6 times, most recently
from
August 9, 2023 16:50
a27ba91
to
419ef12
Compare
Node 14 may well still work with the SDK for quite a while, but we'll no longer actively test against them since they are now characterized as EOL, and it's quite possible that it may stop working entirely in any future release. Change-type: major
otaviojacobi
force-pushed
the
v-18-major
branch
from
August 9, 2023 16:52
419ef12
to
1c3f62e
Compare
How about a commit message like: Ideally the change in the return type of the whoami could be in a separate commit, but I'm fine even w/o that. |
thgreasi
reviewed
Aug 10, 2023
otaviojacobi
force-pushed
the
v-18-major
branch
8 times, most recently
from
August 10, 2023 21:46
abb0322
to
c50ed7b
Compare
otaviojacobi
force-pushed
the
v-18-major
branch
3 times, most recently
from
August 11, 2023 15:40
a980bc8
to
3742ffe
Compare
Change-type: major
Change-type: major
Change-type: minor
Change-type: major
Change-type: major
Change-type: minor
Change-type: major
otaviojacobi
force-pushed
the
v-18-major
branch
from
August 17, 2023 18:38
3742ffe
to
86a7768
Compare
thgreasi
approved these changes
Aug 17, 2023
We should not have any code any more relying on these. Change-type: major
otaviojacobi
force-pushed
the
v-18-major
branch
from
August 17, 2023 18:44
86a7768
to
447aa40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: major
See: https://balena.zulipchat.com/#narrow/stream/345890-balena-io/topic/node-sdk-v18
Contributor checklist