Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V18 Major #1370

Merged
merged 9 commits into from
Aug 17, 2023
Merged

V18 Major #1370

merged 9 commits into from
Aug 17, 2023

Conversation

otaviojacobi
Copy link
Contributor

@otaviojacobi otaviojacobi commented Aug 8, 2023

Change-type: major

See: https://balena.zulipchat.com/#narrow/stream/345890-balena-io/topic/node-sdk-v18


Contributor checklist
  • Includes tests
  • Includes typings
  • Includes updated documentation
  • Includes updated build output

@otaviojacobi otaviojacobi changed the title Drops support to node 14 V18 Major Aug 8, 2023
@otaviojacobi otaviojacobi force-pushed the v-18-major branch 6 times, most recently from a27ba91 to 419ef12 Compare August 9, 2023 16:50
Node 14 may well still work with the SDK for
quite a while, but we'll no longer actively test
against them since they are now
characterized as EOL, and it's quite possible
that it may stop working entirely in any future
release.

Change-type: major
@thgreasi
Copy link
Member

How about a commit message like:
BREAKING: Support non-user API keys in auth.isLoggedIn() & whoami()

Ideally the change in the return type of the whoami could be in a separate commit, but I'm fine even w/o that.

src/auth.ts Outdated Show resolved Hide resolved
src/auth.ts Outdated Show resolved Hide resolved
src/auth.ts Outdated Show resolved Hide resolved
We should not have any code any more
relying on these.

Change-type: major
@otaviojacobi otaviojacobi marked this pull request as ready for review August 17, 2023 18:53
@thgreasi thgreasi merged commit f1482fd into master Aug 17, 2023
49 checks passed
@thgreasi thgreasi deleted the v-18-major branch August 17, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants