organization-invite: Fix throwing a typed error when passing an unkon…

…wn role Change-type: patch
balena-io · Aug 23, 2023 · d9d9293 · d9d9293
1 parent 8f6eb98
commit d9d9293
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/models/organization-invite.ts b/src/models/organization-invite.ts
@@ -167,7 +167,7 @@ const getOrganizationInviteModel = function (
 				message,
 			};
 			if (roles) {
-				const [{ id: roleId }] = roles;
+				const roleId = roles[0]?.id;
 				// Throw if the user provided a roleName, but we didn't find that role
 				if (!roleId && roleName) {
 					throw new errors.BalenaOrganizationMembershipRoleNotFound(roleName);

diff --git a/tests/integration/models/organizationInvite.spec.ts b/tests/integration/models/organizationInvite.spec.ts
@@ -107,8 +107,10 @@ describe('Organization Invite Model', function () {
 							},
 						);
 						await expect(promise).to.be.rejected.then((error) => {
-							expect(error).to.have.property('code', 'BalenaRequestError');
-							expect(error).to.have.property('statusCode', 404);
+							expect(error).to.have.property(
+								'code',
+								'BalenaOrganizationMembershipRoleNotFound',
+							);
 							expect(error)
 								.to.have.property('message')
 								.that.contains(