Refactor LBP Tests #1270
Open
Refactor LBP Tests #1270
+957
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaobrunoah
commented
Feb 5, 2025
| @@ -322,7 +323,7 @@ contract LBPool is ILBPool, WeightedPool, BaseHooks { | |||
| revert IVaultErrors.InvalidTokenConfiguration(); | |||
| } | |||
|
|
|||
| return pool == address(this); | |||
| return pool == address(this) && factory == _trustedFactory; | |||
There was a problem hiding this comment.
Not sure if we should check the factory here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors and add new tests to LBPs. The refactor includes a base file to test LBPs and a deployer that can reuse hardhat artifacts in forge tests.
Type of change
Checklist:
main, or there's a description of how to merge