-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CoW AMM Router: CoW Sender transfers to Vault upfront (No approval) #1264
Open
joaobrunoah
wants to merge
66
commits into
main
Choose a base branch
from
cow-router-upfront-transfer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+525
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndymionJkb
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty straightforward; just some naming/comment suggestions.
Co-authored-by: EndymionJkb <[email protected]>
Co-authored-by: Juan Ignacio Ubeira <[email protected]>
EndymionJkb
reviewed
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sender (
CoW Settlement
, or any EOA/contract calling the CoW Router) currently needs to give approval to the router, so the router is able to transfer funds from the sender to the vault. However, this approach is not very flexible, in a way that if the token has any fee on transfer implemented, the router reverts.In order to simplify this interaction and don't rely on approvals, the sender can transfer the funds directly to the vault, and only inform the router what's the amount that has been transferred (transferHint). This approach is more flexible, the user is able to transfer more tokens in case of a fee on transfer, or any other use case that requires more flexibility.
Type of change
Checklist:
main
, or there's a description of how to merge