Aggregated fee sweeper #1254
Open
Aggregated fee sweeper #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r validation; and pass a burner address on sweep
# Conflicts: # pkg/interfaces/contracts/standalone-utils/IProtocolFeeSweeper.sol # pkg/standalone-utils/contracts/ProtocolFeeSweeper.sol
# Conflicts: # pkg/interfaces/contracts/standalone-utils/IProtocolFeeSweeper.sol # pkg/standalone-utils/contracts/ProtocolFeeSweeper.sol
# Conflicts: # pkg/interfaces/contracts/standalone-utils/IProtocolFeeBurner.sol # pkg/standalone-utils/contracts/test/ProtocolFeeBurnerMock.sol
# Conflicts: # pkg/standalone-utils/contracts/ProtocolFeeSweeper.sol # pkg/standalone-utils/test/foundry/ProtocolFeeSweeper.t.sol
# Conflicts: # pkg/interfaces/contracts/standalone-utils/IProtocolFeeSweeper.sol # pkg/standalone-utils/contracts/ProtocolFeeSweeper.sol # pkg/standalone-utils/contracts/test/ProtocolFeeBurnerMock.sol # pkg/standalone-utils/test/foundry/ProtocolFeeSweeper.t.sol
12 tasks
# Conflicts: # pkg/interfaces/contracts/standalone-utils/IProtocolFeeBurner.sol # pkg/interfaces/contracts/standalone-utils/IProtocolFeeSweeper.sol # pkg/standalone-utils/contracts/ProtocolFeeSweeper.sol # pkg/standalone-utils/contracts/test/ProtocolFeeBurnerMock.sol # pkg/standalone-utils/test/foundry/ProtocolFeeSweeper.t.sol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Built on #1251 (base fee sweeper), this version "aggregates" collection from multiple pools. Instead of taking a pool argument and doing the withdrawal in the sweeper (requiring permission), it assumes the off-chain process has both collected and withdrawn the protocol fees to the sweeper (i.e, called withdrawal functions with the fee sweeper as the recipient), so that the token balances are in the sweeper.
Pending Cow Router release (the point at which other contracts start sending fees to the sweeper; until then, it's fine to assume that the only source of tokens is the internal withdrawals in the sweeper).
It can then check these balances against a threshold, and sweep all (or optionally only some) of the token balance through a burner to a final recipient. This is more efficient if there are many pools with the same fee tokens (especially low liquidity pools), since the burns can be done less frequently, and with higher balances.
Type of change
Checklist:
main, or there's a description of how to mergeIssue Resolution