Retrieve RegistryAccess directly from the server for caster tome registry
#1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than trying to make use of a specific Overworld level from the started server for
CasterTomeRegistryand doing so only for aRegistryAccess, it would make more sense for the latter to be retrieved directly from the started server itself independently of any level.In situations such as when using the test server provided by NeoForge and ModDevGradle for unit testing, this prevents any such test runs from crashing and hanging due to the fact that the test server doesn't have any levels to speak of and returns
nullwhen trying to retrieve them, which up until now was never checked or accounted for.