Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix useYarn logic in getLockFileName (See issues-95) #102

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

YenHub
Copy link
Contributor

@YenHub YenHub commented Jun 21, 2021

Hey @bahmutov

I believe this PR should address the issue highlighted in #95

I have moved the logic which sets yarnFilename, and in turn useYarn.

It now passes this value into the early return if usePackageLock is false.

Is this the correct approach to handle the issue?

Hope this helps!

Thanks

YenHub :o)

@bahmutov
Copy link
Owner

bahmutov commented Jul 6, 2021

Makes sense, thank you for opening a pull request. To really lose the issue, I believe we would need an example with its own github workflow

@bahmutov bahmutov merged commit 1d29277 into bahmutov:master Jul 6, 2021
@github-actions
Copy link

github-actions bot commented Jul 6, 2021

🎉 This PR is included in version 1.7.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants