Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pnpm #133

Open
MichaelDeBoey opened this issue May 6, 2022 · 0 comments
Open

Add support for pnpm #133

MichaelDeBoey opened this issue May 6, 2022 · 0 comments

Comments

@MichaelDeBoey
Copy link

MichaelDeBoey commented May 6, 2022 •
edited
Loading

Currently, this Action is only looking for an package-lock.json/npm-shrinkwrap.json or yarn.lock.
It would be awesome if it would look for pnpm-lock.yaml/pnpm-lock.yml as well.

npm-install/index.js

Line 148 in 04d753f

lockFilename: useYarn ? yarnFilename : npmFilename

Use-case for this: we're using this Action in all @remix-run default stacks (indie-stack, blues-stack & grunge-stack), but people using Remix are either using npm, pnpm or yarn.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MichaelDeBoey