fixups: context, flip NamespacedName, type cast "stunnel"

Co-authored-by: John Strunk <[email protected]>
backube · Nov 12, 2021 · d374eff · d374eff
1 parent 8505c12
commit d374eff
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/transport/stunnel/server.go b/transport/stunnel/server.go
@@ -140,7 +140,7 @@ func (s *server) MarkForCleanup(ctx context.Context, c ctrlclient.Client, key, v
 			Namespace: s.NamespacedName().Namespace,
 		},
 	}
-	return utils.UpdateWithLabel(context.TODO(), c, secret, key, value)
+	return utils.UpdateWithLabel(ctx, c, secret, key, value)
 }
 
 func (s *server) reconcileConfig(ctx context.Context, c ctrlclient.Client) error {
@@ -165,8 +165,8 @@ func (s *server) reconcileConfig(ctx context.Context, c ctrlclient.Client) error
 
 	stunnelConfigMap := &corev1.ConfigMap{
 		ObjectMeta: metav1.ObjectMeta{
-			Namespace: s.NamespacedName().Namespace,
 			Name:      s.prefixedName(stunnelConfig),
+			Namespace: s.NamespacedName().Namespace,
 		},
 	}
 

diff --git a/transport/stunnel/stunnel.go b/transport/stunnel/stunnel.go
@@ -19,7 +19,7 @@ const (
 )
 
 const (
-	TransportTypeStunnel = "stunnel"
+	TransportTypeStunnel transport.Type = "stunnel"
 	Container            = "stunnel"
 )
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,7 +19,7 @@ const ( @@
     )
     const (
-    	TransportTypeStunnel = "stunnel"
+    	TransportTypeStunnel transport.Type = "stunnel"
     	Container            = "stunnel"
     )
@@ Expand Down @@