Issue #411: Add config-clear command, fix bug in config-set. #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorkshire-pudding
requested changes
Jul 29, 2024
There was a problem hiding this comment.
Thanks @bugfolder - confirmed the bug you mentioned and that this fixes it as well as the new function.
One change please:
The test results currently don't confirm that this function works:
Config Commands
✔ Config get command works
✔ Config set command works
✔ Config export command works
✔ Config import command works
Therefore, please can you split out the new test element into its own function (i.e. public function test_config_clear_command_works())?
yorkshire-pudding
approved these changes
Jul 30, 2024
yorkshire-pudding
merged commit b48206f
into
backdrop-contrib:1.x-1.x
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #411.