Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

린트 에러 수정, any 타입 제거 #250

Merged
merged 4 commits into from
Oct 3, 2023
Merged

린트 에러 수정, any 타입 제거 #250

merged 4 commits into from
Oct 3, 2023

Conversation

tirr-c
Copy link
Contributor

@tirr-c tirr-c commented Sep 28, 2023

  • request body를 Zod로 검사하고 직접 짠 검사 코드를 제거함
  • any 박멸 (@typescript-eslint/no-explicit-any)

@tirr-c tirr-c self-assigned this Sep 28, 2023
seojangho
seojangho approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@seojangho seojangho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tirr-c
Copy link
Contributor Author

tirr-c commented Oct 3, 2023

요건 테스트 고치고 머지할게요. 에러코드 바꾸고 그룹 승인처리에 빈 배열 못넣게했더니 좀 터지네...

@tirr-c tirr-c merged commit 20f0180 into master Oct 3, 2023
2 checks passed
@tirr-c tirr-c deleted the typed-codebase branch October 3, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seojangho seojangho seojangho approved these changes

Assignees

@tirr-c tirr-c

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tirr-c @seojangho