Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robocup2023 #325

Open
wants to merge 219 commits into
base: noetic
Choose a base branch
from
Open

Robocup2023 #325

wants to merge 219 commits into from

Conversation

vamsikalagaturu
Copy link
Contributor

Changelog

  • ...
  • ...

Related PRs

Closes #XX
Related to #YY

Checklist:

  • My code doesn't contain unnecessary comment blocks (e.g. unused code, templates of package.xml or CMakeLists.txt)
  • I have updated the package.xml and CMakeLists.txt with the correct dependencies.
  • I have updated the documentation accordingly.

kvnptl and others added 30 commits February 17, 2023 16:19
for view_youbot and realsense dual camera
…k handling

>
Created a new state to handle shelf pick using pregrasp planner instead of MoveIt. Created a new ros param to toggle orientation independent IK for shelf pick.

Co-authored-by: MannavaVivek <[email protected]>
Co-authored-by: kvnptl <[email protected]>
This change introduces a toggle in the orientation-independent IK for shelf pick. It limits the pitch range to between -15.0 and -45.0 degrees.

Co-authored-by: MannavaVivek <[email protected]>
Co-authored-by: kvnptl <[email protected]>
@@ -58,7 +61,13 @@ def get_reachable_pose_and_joint_msg_from_point(self, x, y, z, frame_id):
:returns: (geometry_msgs.msg.PoseStamped, brics_actuator.JointPositions) or None

"""
pitch_ranges = [(0.0, 0.0), (-30.0, 0.0), (-60.0, -30.0), (-90.0, -60.0), (0.0, 10.0)]
# check is_picking_from_shelf from parameter server
self.is_picking_from_shelf = rospy.get_param("/pick_from_shelf_server/pick_statemachine_says_shelf", False)
Copy link
Contributor

@sthoduka sthoduka Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

param name should not be hard coded here. Maybe find a better way to send the info to this node

# self.original_pose_pub.publish(modified_pose)

# check is_picking_from_shelf from parameter server
self.is_picking_from_shelf = rospy.get_param("/pick_from_shelf_server/pick_statemachine_says_shelf", False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

-O3
)
set (CMAKE_BUILD_TYPE Release)
# add_compile_options(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments

event_out.data = "e_failure";
add_to_octree_ = true;
// add_to_octree_ = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment

event_out.data = "e_failure";
add_to_octree_ = true;
// add_to_octree_ = true;
}
//event_out.data = (success) ? "e_success" : "e_failure";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment

@@ -24,7 +24,7 @@
<param name="pointcloud_source_frame_id" value="$(arg pointcloud_source_frame_id)" type="str" />
<param name="debug_mode" value="$(arg debug_mode)" type="bool" />
<param name="dataset_collection" value="true" />
<param name="logdir" value="/tmp/" />
<param name="logdir" value="/home/robocup/perception_debugs/" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't work on all PCs

Copy link
Contributor

@sthoduka sthoduka Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of the perception changes have already been merged in #304

@@ -20,8 +21,12 @@
<remap from="~event_out" to="/mcr_perception/cavity_finder/output/event_out" />

<param name="object_shape_learned_params_file" value="$(arg object_shape_learned_params_file)"/>
<!-- <param name="target_frame" type="string" value="base_link_static"/> -->
<!-- <param name="source_frame" type="string" value="fixed_camera_link"/> -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these files supposed to be empty?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants