Add Python 3 support and fix failing test for Google country filter #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test disambiguation of a place name with country name; do not assume default country selection.
|
Ran |
flibbertigibbet
changed the title
hectcastro
approved these changes
Mar 19, 2018
| @@ -4,6 +4,7 @@ sudo: false | |||
|
|
|||
| python: | |||
| - '2.7' | |||
| - '3.6' | |||
There was a problem hiding this comment.
Because this creates a matrix build, we need to add an additional condition to the on: configuration under deploy: for Python 3.6 so that only that build publishes to PyPi:
on:
tags: true
python: "3.6"
distributions: sdist bdist_wheel
repo: azavea/python-omgeoRan 2to3 conversion tool. Update Travis configuration to test on both python 2 and 3.
Use conditional imports to support both python 2 and 3.
flibbertigibbet
force-pushed
the
feature/kak/fix-tests#45
branch
from
39a3da8
to
af8cc89
Compare
Empty requirements to fix broken Read the Docks build.
flibbertigibbet
force-pushed
the
feature/kak/fix-tests#45
branch
from
752ff11
to
cd1e68e
Compare
|
Added python version to deploy build, and also added empty |
KlaasH
added a commit
that referenced
this pull request
Jul 12, 2019
Per #47, this supports Python 3. Adding a classifier to `setup.py` lets people (and scripts like `caniusepython3`) know that.
KlaasH
added a commit
that referenced
this pull request
Jul 12, 2019
Per #47, this supports Python 3. Adding a classifier to `setup.py` lets people (and scripts like `caniusepython3`) know that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test disambiguation of a place name with country name; do not assume default country selection.
Fixes a test that fails when the Google geocoder key is set.
Fixes #45.
Add Python 3 support by running
2to3and adding backwards support for Python 2 in imports. Adds python 3 to test matrix run on Travis.Closes #16
Connects #43