-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3 support and fix failing test for Google country filter #47
Conversation
Test disambiguation of a place name with country name; do not assume default country selection.
Ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -4,6 +4,7 @@ sudo: false | |||
|
|||
python: | |||
- '2.7' | |||
- '3.6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this creates a matrix build, we need to add an additional condition to the on:
configuration under deploy:
for Python 3.6 so that only that build publishes to PyPi:
on:
tags: true
python: "3.6"
distributions: sdist bdist_wheel
repo: azavea/python-omgeo
Ran 2to3 conversion tool. Update Travis configuration to test on both python 2 and 3.
Use conditional imports to support both python 2 and 3.
39a3da8
to
af8cc89
Compare
Empty requirements to fix broken Read the Docks build.
752ff11
to
cd1e68e
Compare
Added python version to deploy build, and also added empty |
Per #47, this supports Python 3. Adding a classifier to `setup.py` lets people (and scripts like `caniusepython3`) know that.
Per #47, this supports Python 3. Adding a classifier to `setup.py` lets people (and scripts like `caniusepython3`) know that.
Test disambiguation of a place name with country name; do not assume default country selection.
Fixes a test that fails when the Google geocoder key is set.
Fixes #45.
Add Python 3 support by running
2to3
and adding backwards support for Python 2 in imports. Adds python 3 to test matrix run on Travis.Closes #16
Connects #43