Feature/kak/multiple event destinations#1107 #1128
Conversation
Also add flag to destinations to note if it is only for use with an asssociated event.
Remove development images for default event that are too narrow to be the wide image. Fixes not being able to save event without changing image(s).
Not yet implementing event-only destinations.
There was a problem hiding this comment.
Looks good 👍
I ran into some trouble with editing the Crazy Philadelphia Eddie event (missing CrazyPhiladelphiaEddie_3.jpg in the media directory) which I ended up solving by manually renaming a file. But I don't know if that would affect other people or was an artifact of the particular chain of branches and migrations in my database (plus the fact that I'm reluctant to destroy my database altogether).
| obj['destinations'] = [set_destination_properties(x) for x in event.destinations.all()] | ||
|
|
||
| # if the first related destination belongs to Watershed Alliance, so does this event | ||
| obj['watershed_alliance'] = event.destinations.first().watershed_alliance if event.destinations.count() else False |
There was a problem hiding this comment.
Is the first one special, or should any Watershed Alliance destination cause the event to get the label? This could also be something like event.destinations.filter(watershed_alliance=True).exists(), right?
There was a problem hiding this comment.
This is an interim fix that should be revisited with #1127, when we have answers on how these properties should be assigned (does it apply if any destination has the property? if all do?).
|
The missing image you encountered was likely due to the fix here removing test images that were too small to pass validation, and shouldn't be an issue for newly created VMs. |
flibbertigibbet
deleted the
feature/kak/multiple-event-destinations#1107
branch
Overview
Allow an event to be associated with multiple destinations, in order to support the upcoming "tours" feature.
Demo
The field for associated destinations in the
adminsite UI for editing an event has changed from a drop-down to a multi-select field:Notes
Originally I was planning on doing #1125 as well as part of this task, but after discussion with @lederer decided to break that out into a separate task, and also added #1126 and #1127. Instead, this PR only handles the data migration and minimal logic changes to prevent errors. There are a couple of places where an event is still assumed to have a single destination associated with it (if any), where for now it simply uses the first destination for the event: in routing, and in setting properties such as flags.
There is a backwards migration, but for it to work, the old
destinationfield must be added back alongside the newdestinationsfield in the model before running the backward migration.I also fixed a small issue with two of the images for the default development event not being wide enough; they were set by the migration, but editing the event later would fail validation on the image.
Testing Instructions
Closes #1107