Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct Links for Privacy Policy and Terms of Service in "Subscribe to Newsletter" Modal #2595

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

PrityanshuSingh
Copy link
Contributor

πŸ› οΈ Fixes Issue

Fixes: #2518

πŸ‘¨β€πŸ’» Description

What does this PR do?

This PR resolves the issue of incorrect links for the Privacy Policy and Terms of Service in the "Subscribe to Newsletter" modal. It updates the links to ensure they redirect users to the correct pages, enhancing both the credibility and functionality of the modal.

  • Fixes 404 redirection issue by providing correct URLs for Privacy Policy and Terms of Service.

πŸ“„ Type of Change

  • Bug fix (non-breaking change which fixes an issue)

βœ… Checklist

  • I am a participant of GSSoC-ext.
  • I have followed the contribution guidelines of this project.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have added documentation to explain my changes.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

🀝 GSSoC Participation

  • This PR is submitted under the GSSoC program.
  • I have taken prior approval for this fix.

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
fin-veda βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 1, 2024 6:20pm

Copy link

github-actions bot commented Nov 1, 2024

Thank you for submitting your chaotic pull request! πŸ™Œ We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@PrityanshuSingh
Copy link
Contributor Author

@sampadatiwari30 kindly assign me labels accordingly after successful merge of the PR.

Copy link

netlify bot commented Nov 1, 2024

βœ… Deploy Preview for getfinveda ready!

Name Link
πŸ”¨ Latest commit b6f7e39
πŸ” Latest deploy log https://app.netlify.com/sites/getfinveda/deploys/67251bdc0938720008b4d582
😎 Deploy Preview https://deploy-preview-2595--getfinveda.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 29
Accessibility: 66
Best Practices: 75
SEO: 73
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sampadatiwari30 sampadatiwari30 merged commit 4cb1e2c into ayush-that:main Nov 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Incorrect Links for Privacy Policy and Terms of Service in "Subscribe to Newsletter" Modal
2 participants