Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix active link functionality in navbar for accurate page indication #2567

Merged

Conversation

ritiksingh-01
Copy link
Contributor

@ritiksingh-01 ritiksingh-01 commented Nov 1, 2024

πŸ› οΈ Fixes Issue

Fixes: #2537

πŸ‘¨β€πŸ’» Description

What does this PR do?

This PR addresses an issue with the navbar where the active link is not correctly displaying, causing user confusion about the current page. The active state functionality has been fixed, ensuring that the correct navbar link is highlighted based on the user's current page. This enhancement improves navigation clarity and user experience across the platform.

  • Briefly describe the feature or bug fix you've implemented.
  • Highlight any major changes or added functionality.
  • Mention how it enhances the project.

πŸ“„ Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (adds or updates related documentation)

πŸ“· Screenshots/GIFs (if any)

active.link.mp4

βœ… Checklist

  • I am a participant of GSSoC-ext.
  • I have followed the contribution guidelines of this project.
  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have added documentation to explain my changes.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

🀝 GSSoC Participation

  • This PR is submitted under the GSSoC program.
  • I have taken prior approval for this feature/fix.

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
fin-veda βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 1, 2024 10:52am

Copy link

github-actions bot commented Nov 1, 2024

Thank you for submitting your chaotic pull request! πŸ™Œ We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 1, 2024

βœ… Deploy Preview for getfinveda ready!

Name Link
πŸ”¨ Latest commit 9848879
πŸ” Latest deploy log https://app.netlify.com/sites/getfinveda/deploys/6724b2f216e4920008aada6d
😎 Deploy Preview https://deploy-preview-2567--getfinveda.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26
Accessibility: 70
Best Practices: 75
SEO: 73
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sampadatiwari30 sampadatiwari30 merged commit f5a5ff3 into ayush-that:main Nov 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Active Link Not Functioning in Navbar
2 participants