Fix crash when viewing nat46 kernel module config #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the commit 91b8e68 Add network namespace awareness to nat46 the network namespace of the /proc/net file is now passed via single_open() to nat46_proc_show(). However, the priv arg passed to single_open() is accessed via the seq_file, not the second value. When using the second value, the 'network namespace' is invalid and causes a kernel oops. Access the network namespace in nat46_proc_show from struct seq_file.
|
Is there a way to make the code conditional on the kernel version, so it could work both before and after the change ? |
Sorry for the delay in my answer. This was an error in my original patch, from what I can see the See: |
ayourtch
approved these changes
Aug 12, 2024
|
Thanks a lot for the clarification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the commit
91b8e68 Add network namespace awareness to nat46
the network namespace of the /proc/net file is now passed via single_open() to nat46_proc_show(). However, the priv arg passed to single_open() is accessed via the seq_file, not the second value.
When using the second value, the 'network namespace' is invalid and causes a kernel oops.
Access the network namespace in nat46_proc_show from struct seq_file.