feat: pkg followups #1381
Open
feat: pkg followups #1381
+102
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this something we can merge? i know the code signing part is still not possible, but is this? |
|
I think so, yeah. Because of the init code, rebasing this is going to make the most sense after config 1.0 is merged. |
mistydemeo
force-pushed
the
pkg-followups
branch
from
3f9c138 to
7511a70
Compare
mistydemeo
force-pushed
the
pkg-followups
branch
from
7511a70 to
ba532e0
Compare
|
This conflicts, very badly, with #1653 and so this shouldn't be merged until that PR is done. The init code here will have to be 100% rewritten in order to be usable. It follows the patterns of the surrounding code, so it should ideally be obvious how to rewrite it to work with the new config structure once the surrounding code has been rewritten and is merged. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains two commits broken out from #469 so that we can ship them later: the documentation, and the user-facing
initcode. This can be merged later so that, if we decide to, we can ship unadvertised pkg support early and then make it officially supported later.