-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add confidence votes deck #225
base: main
Are you sure you want to change the base?
Conversation
As part of our object/key results we vote on confidence in finishing the KR by the end of a quarter. And we vote it from 0-10
Hello, Thank you for you PR! Adding a new deck also requires updating the back-end code: https://github.com/axeleroy/self-host-planning-poker/blob/main/flask/gamestate/deck.py (the back-end saves the deck to the current game and checks that users do not send bogus values) But I believe you could add new values to the |
I'll update it per your recommendation. |
@axeleroy updated. I extended the TRUST_VOTE instead of adding a new one. |
Great, but you still have to add the new values in the back-end, otherwise it'll just throw an error and won't update the selected value. |
Gotcha, added that as well. |
@axeleroy do you require me to add anything else to get this merged? Please let me know :) |
@axeleroy can this be merged, please? |
@axeleroy can this be merged so we can use the new changes? |
As part of our objective/key results, we vote on confidence in finishing the KR by the end of a quarter. And we vote it from 0-10.
We love your app. Please merge this and release it for us to use this feature. It'd be incredibly useful to have it in the dropdown.