Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fzf to select a package if none supplied #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gergesh
Copy link
Contributor

@gergesh gergesh commented Jan 16, 2024

No description provided.

@ax
Copy link
Owner

ax commented Feb 6, 2024

why?

@gergesh
Copy link
Contributor Author

gergesh commented Feb 6, 2024

Because sometimes you (read: I) don't remember the exact package name you'd like to pull and fuzzy searching for "Facebook" gets the job done the fastest

@CrazyChaoz
Copy link

i like the idea, but it would add potential interactivity to a static command -> using it in scripts might break functionality, so making it optional and hiding it behind an argument would probably be better

@gergesh
Copy link
Contributor Author

gergesh commented Mar 5, 2024

The current implementation does not break anything, as it only changes behavior in the case where a package name wasn't supplied - not a valid condition currently.

@ax
Copy link
Owner

ax commented Mar 11, 2024

Sorry @gergesh, I personally don't like the idea of adding another dependency just to have a package name guessed. Lemme keep this thread here for a while, let's see what the community thinks about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants