add a check to determine if horovod.torch import succeeds #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaoliu-aws
force-pushed
the
zao/hvd_imported
branch
from
88f1f22
to
f8be17b
Compare
| try: | ||
| import horovod.torch as hvd | ||
|
|
||
| # This redundant import is necessary because horovod does not raise an ImportError if the library is not present | ||
| import torch # noqa | ||
| #make sure the library is correctly imported | ||
| hvd.init() |
There was a problem hiding this comment.
Do we know if this could interfer with other distribution strategies? I'm worried running init on horovod might cause a problem if the user is running SMDDP or DDP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import horovod.torch does not raise exception even if it is not fully successful. Add init() function to catch it.