Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Setting the default spark_version value from pyspark.__version__ #175

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aagumin
Copy link

@aagumin aagumin commented Nov 23, 2023

*Issue #170

Description of changes:
The default value for the SPARK_VERSION variable will be taken from pyspark.__version__. In case of problems, the user also sets the environment variable himself

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@chenliu0831 chenliu0831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I think this is an acceptable solution (although not airtight :)). A few comments

pydeequ/configs.py Show resolved Hide resolved
tests/test_config.py Outdated Show resolved Hide resolved
@chenliu0831
Copy link
Contributor

chenliu0831 commented Dec 5, 2023

Test is failing - @Argo3V5A would you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants