fix: add assertion and hints for isContainedIn and hasPattern #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_one and use as default assertion
This was referenced Sep 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #142
Description of changes:
FIx #142. The constraint suggested comes Deequ and the isContainedIn method did not support
assertionandhintparameters. This PR adds it back.In addition, we add the
is_onecheck function and set it as default for hasPattern and isContainedIn function. This is consistent with the Deequ's default value for assertion, see https://github.com/awslabs/deequ/blob/d3dbe2d77563fdbe0acaadcf55bd84e5f688027f/src/main/scala/com/amazon/deequ/checks/Check.scala#L1084.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.