chore(opensearchserverless): refactor cdk construct #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdemayyildiz
requested review from
krokoko,
MichaelWalker-git,
dineshSajwan and
alexa-perlov
|
Thanks @erdemayyildiz ! Could you please run a full build locally, it seems the build was failing because of a mutation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #737
refactor for opensearchserverless constructs that follows best practices https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md
created interface for VectorCollection extended from IResource - https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md#construct-interface
created VectorCollectionBase implements IVectorCollection - https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md#abstract-base
created default metrics - https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md#metrics
created import methods
fromCollectionName,fromCollectionAttributes- https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md#importsdeveloped additional test cases for refactored lines.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.