Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bedrock): prompt flows #790

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat(bedrock): prompt flows #790

wants to merge 3 commits into from

Conversation

aws-rafams
Copy link
Contributor

@aws-rafams aws-rafams commented Nov 6, 2024 •
edited
Loading

Fixes #647

Draft version

  • Interfaces
  • Testing
  • Doc Updates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@aws-rafams aws-rafams requested a review from a team as a code owner November 6, 2024 18:35
@aws-rafams aws-rafams marked this pull request as draft November 6, 2024 18:35
krokoko
krokoko reviewed Nov 7, 2024
View reviewed changes
src/cdk-lib/bedrock/prompt-flows/flow.ts
// Execution Role
// ------------------------------------------------------
// Create base execution role
this.executionRole = new iam.Role(this, "AmazonBedrockExecutionRoleForFlows_", {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can allow the user to pass his own role

@krokoko
Copy link
Collaborator

krokoko commented Nov 7, 2024

Overall it looks good to me so far, great job @aws-rafams ! Comments:

  • We can let the user provide his own role (see comment above)
  • Maybe we could (in the future, not blocking) add addNode method(s) to Flows so it builds the FlowDefinition as you build your app, and you don't need to load them all through .fromNodes([...]) at the end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krokoko krokoko krokoko left review comments

@MichaelWalker-git MichaelWalker-git Awaiting requested review from MichaelWalker-git MichaelWalker-git is a code owner automatically assigned from awslabs/generative-ai-cdk-constructs-maintainers

@dineshSajwan dineshSajwan Awaiting requested review from dineshSajwan dineshSajwan is a code owner automatically assigned from awslabs/generative-ai-cdk-constructs-maintainers

@alexa-perlov alexa-perlov Awaiting requested review from alexa-perlov alexa-perlov is a code owner automatically assigned from awslabs/generative-ai-cdk-constructs-maintainers

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
valued-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(bedrock): implement prompt flows
3 participants
@aws-rafams @krokoko @emerging-tech-cdk-constructs-bot