fix(bedrock): adopt best practices #750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore(documentation): update readme to fix issues
…mmarization-appsync-stepfn construct (awslabs#722) * feat(content-gen): update modelid in content gen construct --------- Co-authored-by: Dinesh Sajwan <[email protected]> Co-authored-by: Alain Krok <[email protected]>
Upgrade list of models and DLC images. See details in [workflow run]. [Workflow Run]: https://github.com/awslabs/generative-ai-cdk-constructs/actions/runs/11283958742 ------ *Automatically created by projen via the "code-generation" workflow* Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
Upgrade list of models and DLC images. See details in [workflow run]. [Workflow Run]: https://github.com/awslabs/generative-ai-cdk-constructs/actions/runs/11318853147 ------ *Automatically created by projen via the "code-generation" workflow* Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
Upgrade list of models and DLC images. See details in [workflow run]. [Workflow Run]: https://github.com/awslabs/generative-ai-cdk-constructs/actions/runs/11336903352 ------ *Automatically created by projen via the "code-generation" workflow* Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
aws-rafams
requested review from
krokoko,
MichaelWalker-git,
dineshSajwan and
alexa-perlov
aws-rafams
changed the title
|
Thanks @aws-rafams ! I see some changes not related to this PR in your files (seems to be previous commits), could you please fix the conflicts and merge main back ? I think this should fix it, will review after. Thanks ! |
|
Closing this in favour of #751 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #733
There is an integ test that I can remove after it has been tested.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.