Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tower 0.5 #929

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Conversation

GeorgeHahn
Copy link
Contributor

Hi, hope things are going well! This PR updates the tower crate to version 0.5. Relevant release notes: v0.5.0 release notes. Note I was unable to run the integration tests locally. I can set that up if CI doesn't pass.

📬 Issue #, if available: N/A

✍️ Description of changes: Update the tower crate to version 0.5.

🔏 By submitting this pull request

  • I confirm that I've ran cargo +nightly fmt.
  • I confirm that I've ran cargo clippy --fix.
  • I confirm that I've made a best effort attempt to update all relevant documentation.
  • I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey George, good to see you here. Thanks for the contribution!

Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need to update some of the examples too.

@GeorgeHahn
Copy link
Contributor Author

You as well David!

Pushed two commits. One updates tower in a place I missed, and the other fixes the example that broke.

@calavera calavera merged commit 1c63439 into awslabs:main Oct 3, 2024
5 checks passed
@GeorgeHahn GeorgeHahn deleted the update-tower-to-0.5 branch October 7, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants