Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Serialize for lambda telemetry #759

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

nismotie
Copy link
Contributor

@nismotie nismotie commented Dec 20, 2023

Issue #757 Lambda Extension - Implement Serialize for LambdaTelemetryRecord

Description of changes:
This PR implements the Serialize trait for the LambdaTelemetry struct, as well as its fields, most importantly the LambdaTelemetryRecord enum and its component variants.

I have made a couple choices here and I'm not sure that they are necessarily the best, I'm happy to hear any comments on them:

  • On variants of LambdaTelemetryRecord, I have skipped serialization on fields which are Option::None, as opposed to serializing them to null
  • I have included empty arrays of spans on those variants that have spans

By submitting this pull request:

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@nismotie nismotie closed this Dec 20, 2023
@nismotie nismotie reopened this Dec 20, 2023
@calavera
Copy link
Contributor

  • On variants of LambdaTelemetryRecord, I have skipped serialization on fields which are Option::None, as opposed to serializing them to null

  • I have included empty arrays of spans on those variants that have spans

both of these options sound reasonable to me, thanks!

@calavera calavera merged commit ead7f37 into awslabs:main Dec 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants