Fixes #432, override docker-credential-helpers version fields #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henry118
reviewed
Nov 9, 2023
scripts/build_binary.sh
Outdated
|
|
||
| version_ldflags="" | ||
| version_ldflags="-X ${package_docker}/credentials.Name=docker-credential-ecr-login -X ${package_docker}/credentials.Package=${package_root%/*}" |
There was a problem hiding this comment.
instead of the extra override of these variables in credentials, imo a better option is assigning them with the overridden variables in version, at the initialization time of the program.
There was a problem hiding this comment.
hi @henry118, I updated the PR as suggested.
There was a problem hiding this comment.
Thanks @tnaroska. The change looks good. Can you squash your commits?
henry118
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #432: Release version inconsistent with docker-credential-ecr-login version
Description of changes:
During build, override the name/package/version/revision fields defined in docker-credential-helpers/blob/master/credentials/version.go
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.