Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the generated codewhisperer sigv4 client #765

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

imykhai
Copy link
Contributor

@imykhai imykhai commented Jan 30, 2025

Problem

The codewhisperer sigv4 client is out of date and doesn't include supplementalContext.

Solution

Generated the client from the latest model from the aws-toolkit-vscode

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@imykhai imykhai requested a review from a team as a code owner January 30, 2025 23:10
with:
name: language-servers
name: language-servers-${{ matrix.runs-on }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we face an error in the github actions because two artifacts end up having the same name: language-servers-${{ matrix.runs-on }}

@imykhai imykhai force-pushed the feature/imykhai/update-sigv4-client branch from f9d7e79 to c26e9a3 Compare January 31, 2025 13:14
@imykhai
Copy link
Contributor Author

imykhai commented Jan 31, 2025

The failure in Language Server CI / Test (Windows) (pull_request) isn't related to the current PR.

This is failing on the main branch too - https://github.com/aws/language-servers/actions/runs/13019402292/job/36481420797

@imykhai imykhai merged commit 480f8ec into main Jan 31, 2025
5 of 6 checks passed
@imykhai imykhai deleted the feature/imykhai/update-sigv4-client branch January 31, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants